From: Ben Hutchings <bhutchings@solarflare.com>
To: erazor_de@users.sourceforge.net
Cc: Randy Dunlap <rdunlap@xenotime.net>,
Greg Kroah-Hartman <gregkh@suse.de>,
Jiri Kosina <jkosina@suse.cz>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 3/5] HID: roccat: declaring meaning of pack pragma usage in driver headers
Date: Fri, 26 Nov 2010 20:50:16 +0000 [thread overview]
Message-ID: <1290804616.3051.52.camel@localhost> (raw)
In-Reply-To: <1290801456.18750.164.camel@neuromancer>
On Fri, 2010-11-26 at 20:57 +0100, Stefan Achatz wrote:
> Using pack pragma to prevent padding bytes in binary data structures
> used for hardware communication. Explanation of these pragmas was requested.
[...]
It would be clearer to use the '__packed' macro after each structure
definition instead of using this awful Microsoft extension.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2010-11-26 20:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-26 19:57 [PATCH 3/5] HID: roccat: declaring meaning of pack pragma usage in driver headers Stefan Achatz
2010-11-26 20:50 ` Ben Hutchings [this message]
2010-11-27 7:35 ` [PATCH] HID: roccat: replaced #pragma pack() with __packed macro Stefan Achatz
2010-11-30 17:40 ` [PATCH 3/5] HID: roccat: declaring meaning of pack pragma usage in driver headers Greg KH
2010-12-02 15:04 ` Jiri Kosina
2010-12-02 15:16 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2010-11-26 19:57 Stefan Achatz
2010-11-26 19:57 Stefan Achatz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290804616.3051.52.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=erazor_de@users.sourceforge.net \
--cc=gregkh@suse.de \
--cc=jkosina@suse.cz \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.