From: Ben Hutchings <benh@debian.org>
To: Francois Romieu <romieu@fr.zoreil.com>,
Hayes Wang <hayeswang@realtek.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
David Miller <davem@davemloft.net>,
564628@bugs.debian.org
Subject: Re: [PATCH] net/r8169: Correct the ram code for RTL8111D(L)
Date: Fri, 26 Nov 2010 23:12:26 +0000 [thread overview]
Message-ID: <1290813146.3051.58.camel@localhost> (raw)
In-Reply-To: <20101126224914.GA12266@electric-eye.fr.zoreil.com>
[-- Attachment #1: Type: text/plain, Size: 1176 bytes --]
On Fri, 2010-11-26 at 23:49 +0100, Francois Romieu wrote:
> Ben Hutchings <benh@debian.org> :
> > On Fri, 2010-11-26 at 19:54 +0800, Hayes Wang wrote:
> > > Correct the binary code (Low pass filter & DLY_CAP fine tune from uC).
> > > The incorrect ram code would make the nic working abnormally.
> > [...]
> >
> > I'm glad you finally acknowledge that this is code rather than simple
> > register initialisation.
>
> I am not sure that Hayes is a native english speaker.
>
> I am glad to see him posting here.
Right.
Hayes, by 'you' I meant Realtek, not you personally. If my reply seemed
aggressive, I apologise.
> [...]
> > Below are the changes Debian currently applies in preparation for proper
> > licencing of the firmware.
>
> Do you have some scripts to convert the data at hand ?
[...]
No, it's easy enough to convert a single array by copying it into a C
file that dumps it to stdout (assuming the file's byte order is defined
to match your own machine).
It might be worth adding some sort of header with a version and
checksum. Your choice, really.
Ben.
--
Ben Hutchings, Debian Developer and kernel team member
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2010-11-26 23:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-26 11:54 [PATCH] net/r8169: Correct the ram code for RTL8111D(L) Hayes Wang
2010-11-26 13:50 ` Ben Hutchings
2010-11-26 22:49 ` Francois Romieu
2010-11-26 23:12 ` Ben Hutchings [this message]
2010-11-29 3:47 ` hayeswang
2010-11-29 23:33 ` Francois Romieu
2010-11-30 0:13 ` Stephen Hemminger
2010-11-30 6:37 ` hayeswang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290813146.3051.58.camel@localhost \
--to=benh@debian.org \
--cc=564628@bugs.debian.org \
--cc=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.