From: Ben Hutchings <bhutchings@solarflare.com>
To: Szymon Janc <szymon@janc.net.pl>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 5/6] forcedeth: use KERN_ facility level in printk
Date: Sat, 27 Nov 2010 19:04:01 +0000 [thread overview]
Message-ID: <1290884641.3292.0.camel@localhost> (raw)
In-Reply-To: <1290883188-2078-6-git-send-email-szymon@janc.net.pl>
On Sat, 2010-11-27 at 19:39 +0100, Szymon Janc wrote:
> Signed-off-by: Szymon Janc <szymon@janc.net.pl>
> ---
> drivers/net/forcedeth.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
> index 2f092d7..a2b6681 100644
> --- a/drivers/net/forcedeth.c
> +++ b/drivers/net/forcedeth.c
> @@ -958,7 +958,7 @@ static int reg_delay(struct net_device *dev, int offset, u32 mask, u32 target,
> delaymax -= delay;
> if (delaymax < 0) {
> if (msg)
> - printk("%s", msg);
> + printk(KERN_WARNING "%s", msg);
No, msg already includes a log level.
Ben.
> return 1;
> }
> } while ((readl(base + offset) & mask) != target);
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2010-11-27 19:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-27 18:39 [PATCH 0/6] Forcedeth code style cleanup Szymon Janc
2010-11-27 18:39 ` [PATCH 1/6] forcedeth: fix multiple code style issues Szymon Janc
2010-11-27 18:39 ` [PATCH 2/6] forcedeth: remove unnecessary checks before kfree Szymon Janc
2010-11-27 18:39 ` [PATCH 3/6] forcedeth: include <linux/io.h> and <linux/uaccess.h> instead of <asm/io.h> and <asm/uaccess.h> as suggested by checkpatch Szymon Janc
2010-11-27 18:39 ` [PATCH 4/6] forcedeth: do not use assignment in if conditions Szymon Janc
2010-11-27 18:39 ` [PATCH 5/6] forcedeth: use KERN_ facility level in printk Szymon Janc
2010-11-27 19:04 ` Ben Hutchings [this message]
2010-11-27 19:45 ` Joe Perches
2010-11-28 9:05 ` Michał Mirosław
2010-11-28 9:11 ` Joe Perches
2010-11-27 18:39 ` [PATCH 6/6] forcedeth: use usleep_range not msleep for small sleeps Szymon Janc
2010-11-29 2:07 ` [PATCH 0/6] Forcedeth code style cleanup David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290884641.3292.0.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=szymon@janc.net.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.