From: Pavel Shilovsky <piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH 1/6] CIFS: Make cifsFileInfo_put work with strict cache mode (try #4)
Date: Sun, 28 Nov 2010 11:12:47 +0300 [thread overview]
Message-ID: <1290931972-2770-2-git-send-email-piastryyy@gmail.com> (raw)
In-Reply-To: <1290931972-2770-1-git-send-email-piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On strict cache mode when we close the last file handle of the inode we
should set invalid_mapping flag on this inode to prevent data coherency
problem when we open it again but it has been modified by other clients.
Signed-off-by: Pavel Shilovsky <piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
fs/cifs/cifs_fs_sb.h | 1 +
fs/cifs/file.c | 8 ++++++++
2 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/fs/cifs/cifs_fs_sb.h b/fs/cifs/cifs_fs_sb.h
index e9a393c..be7b159 100644
--- a/fs/cifs/cifs_fs_sb.h
+++ b/fs/cifs/cifs_fs_sb.h
@@ -40,6 +40,7 @@
#define CIFS_MOUNT_FSCACHE 0x8000 /* local caching enabled */
#define CIFS_MOUNT_MF_SYMLINKS 0x10000 /* Minshall+French Symlinks enabled */
#define CIFS_MOUNT_MULTIUSER 0x20000 /* multiuser mount */
+#define CIFS_MOUNT_STRICT_IO 0x40000 /* strict cache mode */
struct cifs_sb_info {
struct rb_root tlink_tree;
diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index b857ce5..f853bf0 100644
--- a/fs/cifs/file.c
+++ b/fs/cifs/file.c
@@ -264,6 +264,7 @@ void cifsFileInfo_put(struct cifsFileInfo *cifs_file)
struct inode *inode = cifs_file->dentry->d_inode;
struct cifsTconInfo *tcon = tlink_tcon(cifs_file->tlink);
struct cifsInodeInfo *cifsi = CIFS_I(inode);
+ struct cifs_sb_info *cifs_sb = CIFS_SB(inode->i_sb);
struct cifsLockInfo *li, *tmp;
spin_lock(&cifs_file_list_lock);
@@ -279,6 +280,13 @@ void cifsFileInfo_put(struct cifsFileInfo *cifs_file)
if (list_empty(&cifsi->openFileList)) {
cFYI(1, "closing last open instance for inode %p",
cifs_file->dentry->d_inode);
+
+ /* in strict cache mode we need invalidate mapping on the last
+ close because it may cause a error when we open this file
+ again and get at least level II oplock */
+ if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_STRICT_IO)
+ CIFS_I(inode)->invalid_mapping = true;
+
cifs_set_oplock_level(cifsi, 0);
}
spin_unlock(&cifs_file_list_lock);
--
1.7.3.2
next prev parent reply other threads:[~2010-11-28 8:12 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-28 8:12 [PATCH 0/6] Add strict cache mode (try #4) Pavel Shilovsky
[not found] ` <1290931972-2770-1-git-send-email-piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-11-28 8:12 ` Pavel Shilovsky [this message]
[not found] ` <1290931972-2770-2-git-send-email-piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-11-28 11:23 ` [PATCH 1/6] CIFS: Make cifsFileInfo_put work with " Jeff Layton
2010-11-28 8:12 ` [PATCH 2/6] CIFS: Make read call work with strict cache mode (try #2) Pavel Shilovsky
[not found] ` <1290931972-2770-3-git-send-email-piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-11-28 11:28 ` Jeff Layton
2010-11-29 7:35 ` Christoph Hellwig
[not found] ` <20101129073555.GA4573-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2010-11-29 10:41 ` Pavel Shilovsky
[not found] ` <AANLkTimcVhP10LSn5+F+AY+ppnrhKmp_VCsjkKf04cQr-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-11-29 11:34 ` Pavel Shilovsky
2010-11-29 11:56 ` Jeff Layton
2010-11-28 8:12 ` [PATCH 3/6] CIFS: Make write " Pavel Shilovsky
[not found] ` <1290931972-2770-4-git-send-email-piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-11-28 11:36 ` Jeff Layton
[not found] ` <20101128063604.7d9cdded-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-11-28 11:51 ` Jeff Layton
[not found] ` <20101128065100.51c8a404-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-11-29 10:58 ` Pavel Shilovsky
[not found] ` <AANLkTimO9t_wXPZRWXx856-wkG-EwRWTizrCKSo4e2SY-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-11-29 11:37 ` Jeff Layton
[not found] ` <20101129063713.0b71ac09-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-11-29 11:55 ` Pavel Shilovsky
2010-11-29 12:13 ` Suresh Jayaraman
[not found] ` <4CF39901.3010108-l3A5Bk7waGM@public.gmane.org>
2010-11-29 12:16 ` Pavel Shilovsky
2010-11-29 12:26 ` Pavel Shilovsky
[not found] ` <AANLkTimvA08MT5gcy=h_w6UtcTgyvos4X4x+KUTVbM8u-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-11-29 16:24 ` Suresh Jayaraman
[not found] ` <4CF3D3D9.3060500-l3A5Bk7waGM@public.gmane.org>
2010-11-29 17:08 ` Pavel Shilovsky
[not found] ` <AANLkTikB6_nwg+G+pYv9NNeohHPwymjUkv3r-mJkZBxW-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-12-01 9:46 ` Suresh Jayaraman
[not found] ` <4CF61979.5080505-l3A5Bk7waGM@public.gmane.org>
2010-12-01 16:39 ` Pavel Shilovsky
[not found] ` <AANLkTik1AC5YJV_CtihSobE1mgj1-7tuiBLf7_nDsiv2-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-12-06 11:50 ` Suresh Jayaraman
[not found] ` <4CFCCE17.2010108-l3A5Bk7waGM@public.gmane.org>
2010-12-06 17:55 ` Pavel Shilovsky
2010-11-28 8:12 ` [PATCH 4/6] CIFS: Make cifs_fsync " Pavel Shilovsky
[not found] ` <1290931972-2770-5-git-send-email-piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-11-28 11:42 ` Jeff Layton
[not found] ` <20101128064219.7ca2274c-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-11-28 11:52 ` Jeff Layton
2010-11-28 8:12 ` [PATCH 5/6] CIFS: Make cifs_file_map " Pavel Shilovsky
2010-11-28 8:12 ` [PATCH 6/6] CIFS: Add strictcache mount option " Pavel Shilovsky
2010-11-29 10:54 ` [PATCH 0/6] Add strict cache mode (try #4) Suresh Jayaraman
[not found] ` <4CF3864E.50901-l3A5Bk7waGM@public.gmane.org>
2010-11-29 11:00 ` Pavel Shilovsky
[not found] ` <AANLkTinLbS7V=Ok_Eje=mnrBOkZEJJo9iQ9SYwHsbsag-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-11-29 12:15 ` Suresh Jayaraman
[not found] ` <4CF3995C.4080709-l3A5Bk7waGM@public.gmane.org>
2010-11-29 12:22 ` Pavel Shilovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290931972-2770-2-git-send-email-piastryyy@gmail.com \
--to=piastryyy-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.