All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Daniel Drake <dsd@gentoo.org>,
	Ulrich Kunitz <kune@deine-taler.de>,
	linux-wireless@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>,
	linux-kernel@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: [PATCH V2 4/4] zd1211rw: document need for kmalloc cast
Date: Sun, 28 Nov 2010 02:02:59 -0800	[thread overview]
Message-ID: <1290938579.16349.19.camel@Joe-Laptop> (raw)
In-Reply-To: <1290936606.3467.2.camel@jlt3.sipsolutions.net>

Signed-off-by: Joe Perches <joe@perches.com>
---

V2: Just document the need for the cast

diff --git a/drivers/net/wireless/zd1211rw/zd_chip.c b/drivers/net/wireless/zd1211rw/zd_chip.c
index 87a95bc..dd0bb0c 100644
--- a/drivers/net/wireless/zd1211rw/zd_chip.c
+++ b/drivers/net/wireless/zd1211rw/zd_chip.c
@@ -117,6 +117,7 @@ int zd_ioread32v_locked(struct zd_chip *chip, u32 *values, const zd_addr_t *addr
 
 	/* Allocate a single memory block for values and addresses. */
 	count16 = 2*count;
+	/* zd_addr_t is __nocast, so the kmalloc needs an explicit cast */
 	a16 = (zd_addr_t *) kmalloc(count16 * (sizeof(zd_addr_t) + sizeof(u16)),
 		                   GFP_KERNEL);
 	if (!a16) {



  parent reply	other threads:[~2010-11-28 10:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-28  9:05 [PATCH 0/4] drivers/net: Remove unnecessary [kv][mcz]alloc casts Joe Perches
2010-11-28  9:05 ` [PATCH 1/4] netxen: remove " Joe Perches
2010-11-28  9:05 ` [PATCH 2/4] qlcnic: " Joe Perches
2010-11-28  9:05 ` [PATCH 3/4] vxge: " Joe Perches
2010-11-28  9:05 ` [PATCH 4/4] zd1211rw: " Joe Perches
2010-11-28  9:05   ` Joe Perches
2010-11-28  9:12   ` Johannes Berg
2010-11-28  9:20     ` Joe Perches
2010-11-28  9:30       ` Johannes Berg
2010-11-28  9:50         ` Joe Perches
2010-11-28  9:50           ` Joe Perches
2010-11-28 10:02           ` Johannes Berg
2010-11-28 10:13             ` Joe Perches
2010-11-28 10:13               ` Joe Perches
2010-11-28 10:02         ` Joe Perches [this message]
2010-11-29  1:26 ` [PATCH 0/4] drivers/net: Remove " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290938579.16349.19.camel@Joe-Laptop \
    --to=joe@perches.com \
    --cc=dsd@gentoo.org \
    --cc=johannes@sipsolutions.net \
    --cc=kune@deine-taler.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.