All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <rpurdie@linux.intel.com>
To: Dongxiao Xu <dongxiao.xu@intel.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 0/1][RFC] Optimize file parsing speed
Date: Sun, 28 Nov 2010 14:27:45 +0000	[thread overview]
Message-ID: <1290954465.27143.226.camel@rex> (raw)
In-Reply-To: <cover.1290405852.git.dongxiao.xu@intel.com>

Hi Dongxiao,

On Mon, 2010-11-22 at 14:04 +0800, Dongxiao Xu wrote:
> I found that when parsing bitbake files, most of the variables in
> d.keys() are in distro_tracking_fields.inc, and they are not used in
> normal build.
> 
> This pull request moves some distro related functions in
> utility-tasks.bbclass into distrodata.bbclass, and remove the inclusion
> of distro_tracking_fields.inc from poky.conf. This could gain about 25%
> parsing time saving.

I'm going to take the patch but I'd like to be clear where the speed
gains come from with this change. I suspect some are due to a smaller
number of keys but I also suspect the smaller number of tasks involved
helps too!

Also, a lot of those keys are override keys so perhaps its speeding up
update_data() calls and some of the gain is from there too?

Anyhow, its a good move :)

Cheers,

Richard



  parent reply	other threads:[~2010-11-28 21:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-22  6:04 [PATCH 0/1][RFC] Optimize file parsing speed Dongxiao Xu
2010-11-22  6:02 ` [PATCH 1/1] utility-tasks.bbclass: Move distro related tasks to distrodata.bbclass Dongxiao Xu
2010-11-28 14:27 ` Richard Purdie [this message]
2010-11-29  0:32   ` [PATCH 0/1][RFC] Optimize file parsing speed Tian, Kevin
2010-11-29  5:45   ` Xu, Dongxiao
2010-11-29 12:41     ` Richard Purdie
2010-12-01  1:48       ` Xu, Dongxiao
2010-12-08  6:53       ` Xu, Dongxiao
2010-12-09 14:40         ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290954465.27143.226.camel@rex \
    --to=rpurdie@linux.intel.com \
    --cc=dongxiao.xu@intel.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.