From: Alberto Panizzo <maramaopercheseimorto@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Richard Purdie <rpurdie@rpsys.net>,
Marek Vasut <marek.vasut@gmail.com>, Tejun Heo <tj@kernel.org>,
Axel Lin <axel.lin@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] backlight: l4f00242t03: Fix reset sequence
Date: Sun, 28 Nov 2010 18:13:53 +0100 [thread overview]
Message-ID: <1290964433.3016.2.camel@realization> (raw)
The reset command is part of the init sequence and it take effect
only if the lcd is powered.
Signed-off-by: Alberto Panizzo <maramaopercheseimorto@gmail.com>
---
This patch is built on top of:
http://userweb.kernel.org/~akpm/mmotm/broken-out/drivers-video-backlight-l4f00242t03c-full-implement-fb-power-states-for-this-lcd.patch
drivers/video/backlight/l4f00242t03.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/video/backlight/l4f00242t03.c b/drivers/video/backlight/l4f00242t03.c
index 5d25743..c04aa90 100644
--- a/drivers/video/backlight/l4f00242t03.c
+++ b/drivers/video/backlight/l4f00242t03.c
@@ -62,6 +62,8 @@ static void l4f00242t03_lcd_init(struct spi_device *spi)
regulator_enable(priv->core_reg);
}
+ l4f00242t03_reset(pdata->reset_gpio);
+
gpio_set_value(pdata->data_enable_gpio, 1);
msleep(60);
spi_write(spi, (const u8 *)cmd, ARRAY_SIZE(cmd) * sizeof(u16));
@@ -225,7 +227,6 @@ static int __devinit l4f00242t03_probe(struct spi_device *spi)
}
/* Init the LCD */
- l4f00242t03_reset(pdata->reset_gpio);
l4f00242t03_lcd_init(spi);
priv->lcd_state = FB_BLANK_VSYNC_SUSPEND;
l4f00242t03_lcd_power_set(priv->ld, FB_BLANK_UNBLANK);
--
1.6.3.3
next reply other threads:[~2010-11-28 17:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-28 17:13 Alberto Panizzo [this message]
2010-11-29 15:36 ` [PATCH] backlight: l4f00242t03: Prevent unbalanced calls to regulator enable/disable Alberto Panizzo
2011-01-04 23:59 ` [PATCH] backlight: l4f00242t03: Fix reset sequence Andrew Morton
2011-01-05 0:32 ` Alberto Panizzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290964433.3016.2.camel@realization \
--to=maramaopercheseimorto@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=rpurdie@rpsys.net \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.