All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luciano Coelho <luciano.coelho@nokia.com>
To: ext Shahar Levi <shahar_levi@ti.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH ] wl12xx: BA receiver support
Date: Mon, 29 Nov 2010 11:52:46 +0200	[thread overview]
Message-ID: <1291024366.1673.1.camel@powerslave> (raw)
In-Reply-To: <1290616392-16532-1-git-send-email-shahar_levi@ti.com>

On Wed, 2010-11-24 at 18:33 +0200, ext Shahar Levi wrote:
> Add new ampdu_action ops to support receiver BA.
> The BA initiator session management in FW independently.
> 
> Signed-off-by: Shahar Levi <shahar_levi@ti.com>
> ---

[...]

> diff --git a/drivers/net/wireless/wl12xx/event.c b/drivers/net/wireless/wl12xx/event.c
> index f9146f5..4e053ff 100644
> --- a/drivers/net/wireless/wl12xx/event.c
> +++ b/drivers/net/wireless/wl12xx/event.c
> @@ -241,6 +241,9 @@ static int wl1271_event_process(struct wl1271 *wl, struct event_mailbox *mbox)
>  			wl1271_event_rssi_trigger(wl, mbox);
>  	}
>  
> +	if (vector & BA_SESSION_RX_CONSTRAINT_EVENT_ID)
> +		wl1271_debug(DEBUG_EVENT, "BA_SESSION_RX_CONSTRAINT_EVENT_ID");
> +
>  	if (wl->vif && beacon_loss)
>  		ieee80211_connection_loss(wl->vif);
>  
> diff --git a/drivers/net/wireless/wl12xx/event.h b/drivers/net/wireless/wl12xx/event.h
> index 6cce014..4c697d7 100644
> --- a/drivers/net/wireless/wl12xx/event.h
> +++ b/drivers/net/wireless/wl12xx/event.h
> @@ -67,7 +67,7 @@ enum {
>  	HEALTH_CHECK_REPLY_EVENT_ID		 = BIT(27),
>  	PERIODIC_SCAN_COMPLETE_EVENT_ID		 = BIT(28),
>  	PERIODIC_SCAN_REPORT_EVENT_ID		 = BIT(29),
> -	BA_SESSION_TEAR_DOWN_EVENT_ID		 = BIT(30),
> +	BA_SESSION_RX_CONSTRAINT_EVENT_ID	 = BIT(30),
>  	EVENT_MBOX_ALL_EVENT_ID			 = 0x7fffffff,
>  };

BA_SESSION_RX_CONSTRAING_EVENT_ID is not really used in this patch.
Please move it to the "wl12xx: Stop BA session event from device", where
it makes more sense.

-- 
Cheers,
Luca.


  parent reply	other threads:[~2010-11-29  9:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-24 16:33 [PATCH ] wl12xx: BA receiver support Shahar Levi
2010-11-25  9:52 ` Juuso Oikarinen
2010-11-25 11:49   ` Shahar Levi
2010-11-26  9:56 ` Juuso Oikarinen
2010-11-26 16:37   ` Levi, Shahar
2010-11-29  9:51 ` Juuso Oikarinen
2010-11-29 10:20   ` Shahar Levi
2010-11-29  9:52 ` Luciano Coelho [this message]
2010-11-29 10:17   ` Shahar Levi
  -- strict thread matches above, loose matches on Subject: below --
2010-11-25 13:51 Shahar Levi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291024366.1673.1.camel@powerslave \
    --to=luciano.coelho@nokia.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=shahar_levi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.