All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Mason <chris.mason@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Nick Piggin <npiggin@kernel.dk>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-ext4 <linux-ext4@vger.kernel.org>,
	linux-btrfs <linux-btrfs@vger.kernel.org>,
	Jan Kara <jack@suse.cz>, Eric Sandeen <sandeen@redhat.com>,
	"Theodore Ts'o" <tytso@mit.edu>
Subject: Re: [patch] fs: fix deadlocks in writeback_if_idle
Date: Mon, 29 Nov 2010 19:50:46 -0500	[thread overview]
Message-ID: <1291075500-sup-6320@think> (raw)
In-Reply-To: <20101124144740.bffb2716.akpm@linux-foundation.org>

Excerpts from Andrew Morton's message of 2010-11-24 17:47:40 -0500:
> On Tue, 23 Nov 2010 07:34:07 -0500
> Chris Mason <chris.mason@oracle.com> wrote:
> 
> > For btrfs there's only one bdi per SB, but for most everyone else a disk
> > with a bunch of partitions is going to have multiple filesystems on the
> > same bdi.
> 
> um, please explain why that wasn't idiotic?  The BDI is a
> representation of a backing device and it's *supposed* to provide
> visibility into what's happening against other partitions on the same
> device.  Creating a BDI per SB (it didn't even occur to me to think
> that a filesystem was even able to do this) breaks that.
> 

We don't really have visibility into the other partitions, we all just
pretend they aren't there (this patch being the most recent example).
Yes, it does help prevent N flushers seeking around on the drive but it
does cause problems too.

How is the btrfs one-bdi-per-super different from device mapper's one
bdi per logical volume?  We're all idiots together I suppose.

As for having multiple bdis per FS, that was always a long term goal of
mine when Jens was setting up the new flushers.  I didn't want to
confuse the initial implementation with it though.

-chris

  parent reply	other threads:[~2010-11-30  0:50 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-23 10:02 [patch] fs: fix deadlocks in writeback_if_idle Nick Piggin
2010-11-23 10:11 ` Nick Piggin
2010-11-23 13:18   ` Jan Kara
2010-11-25  3:52     ` Nick Piggin
2010-11-23 10:26 ` Boaz Harrosh
2010-11-23 10:54   ` Nick Piggin
2010-11-23 12:00     ` Boaz Harrosh
2010-11-23 12:34 ` Chris Mason
2010-11-23 12:52   ` Nick Piggin
2010-11-23 18:58     ` Chris Mason
2010-11-24  1:03       ` Nick Piggin
2010-11-24 13:10         ` Jan Kara
2010-11-25  3:53           ` Nick Piggin
2010-11-29 22:26             ` Andrew Morton
2010-11-30  0:01               ` Nick Piggin
2010-12-16  3:12                 ` Nick Piggin
2010-11-24 22:51         ` Andrew Morton
2010-11-25  4:07           ` Nick Piggin
2010-11-24 22:47   ` Andrew Morton
2010-11-25  9:41     ` Boaz Harrosh
2010-11-25 20:30       ` Andrew Morton
2010-11-30  0:50     ` Chris Mason [this message]
2010-11-23 12:54 ` Dmitry
2010-11-23 12:54 ` Dmitry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291075500-sup-6320@think \
    --to=chris.mason@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=jack@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=npiggin@kernel.dk \
    --cc=sandeen@redhat.com \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.