All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com>,
	Intel Linux Wireless <ilw@linux.intel.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH w-t] iwlagn: fix microcode error on 4965
Date: Tue, 30 Nov 2010 15:36:37 +0100	[thread overview]
Message-ID: <1291127797.3624.20.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20101130143339.GC3074@redhat.com>

On Tue, 2010-11-30 at 15:33 +0100, Stanislaw Gruszka wrote:
> Commit dbbf1755b09eef8ff6dd21c8dafe1606f051ce12 "iwlwifi: use
> antenna information in EEPROM" caused 4965 device breakage with
> "Microcode SW error detected.  Restarting 0x82000000." message.
> This patch reverts 4965 part of that commit.
> 
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>

Acked-by: Johannes Berg <johannes@sipsolutions.net>

Thanks!

> ---
>  drivers/net/wireless/iwlwifi/iwl-4965.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/wireless/iwlwifi/iwl-4965.c b/drivers/net/wireless/iwlwifi/iwl-4965.c
> index 9f1d8d8..6788ceb 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-4965.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-4965.c
> @@ -2624,6 +2624,8 @@ struct iwl_cfg iwl4965_agn_cfg = {
>  	.fw_name_pre = IWL4965_FW_PRE,
>  	.ucode_api_max = IWL4965_UCODE_API_MAX,
>  	.ucode_api_min = IWL4965_UCODE_API_MIN,
> +	.valid_tx_ant = ANT_AB,
> +	.valid_rx_ant = ANT_ABC,
>  	.eeprom_ver = EEPROM_4965_EEPROM_VERSION,
>  	.eeprom_calib_ver = EEPROM_4965_TX_POWER_VERSION,
>  	.ops = &iwl4965_ops,



  reply	other threads:[~2010-11-30 14:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-30 13:01 Microcode SW error detected on current wireless-testing Stanislaw Gruszka
2010-11-30 13:16 ` Johannes Berg
2010-11-30 13:49   ` Stanislaw Gruszka
2010-11-30 14:09     ` Johannes Berg
2010-11-30 14:33       ` [PATCH w-t] iwlagn: fix microcode error on 4965 Stanislaw Gruszka
2010-11-30 14:36         ` Johannes Berg [this message]
2010-11-30 15:38         ` Guy, Wey-Yi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291127797.3624.20.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ilw@linux.intel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sgruszka@redhat.com \
    --cc=wey-yi.w.guy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.