From: Johannes Berg <johannes@sipsolutions.net>
To: Bruno Randolf <br1@einfach.org>
Cc: linville@tuxdriver.com, randy.dunlap@oracle.com,
br1@thinktube.com, peterz@infradead.org, blp@cs.stanford.edu,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Lars_Ericsson@telia.com, j@w1.fi, stefanr@s5r6.in-berlin.de,
kosaki.motohiro@jp.fujitsu.com, akpm@linux-foundation.org,
kevin.granade@gmail.com
Subject: Re: [PATCH 2/3] lib: Improve EWMA efficiency by using bitshifts
Date: Thu, 02 Dec 2010 11:20:22 +0100 [thread overview]
Message-ID: <1291285222.3481.45.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20101202101236.22988.1691.stgit@localhost6.localdomain6>
On Thu, 2010-12-02 at 19:12 +0900, Bruno Randolf wrote:
> + /* get bitshift for weight */
> + for (n = 0; !(weight & 1); n++)
> + weight = weight >> 1;
> + WARN_ON(weight > 1 || n < 1);
I'm sure there's something like log2() (and is_power_of_2() for the
warning) in the kernel already -- no need to reimplement it...
johannes
next prev parent reply other threads:[~2010-12-02 10:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 10:12 [PATCH 1/3] ath5k: Use EWMA factor of 1024 instead of 1000 Bruno Randolf
2010-12-02 10:12 ` [PATCH 2/3] lib: Improve EWMA efficiency by using bitshifts Bruno Randolf
2010-12-02 10:20 ` Johannes Berg [this message]
2010-12-02 10:37 ` Bruno Randolf
2010-12-02 10:12 ` [PATCH 3/3] nl80211/mac80211: Report signal average Bruno Randolf
2010-12-07 19:06 ` John W. Linville
2010-12-07 19:17 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291285222.3481.45.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Lars_Ericsson@telia.com \
--cc=akpm@linux-foundation.org \
--cc=blp@cs.stanford.edu \
--cc=br1@einfach.org \
--cc=br1@thinktube.com \
--cc=j@w1.fi \
--cc=kevin.granade@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=peterz@infradead.org \
--cc=randy.dunlap@oracle.com \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.