From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Peter Ujfalusi <peter.ujfalusi@nokia.com>
Subject: Re: [PATCH v2] ASoC: tpa6130a2: Replace DAPM code with direct interface
Date: Thu, 02 Dec 2010 11:50:43 +0000 [thread overview]
Message-ID: <1291290643.3262.47.camel@odin> (raw)
In-Reply-To: <20101202095626.GB19267@rakim.wolfsonmicro.main>
On Thu, 2010-12-02 at 09:56 +0000, Mark Brown wrote:
> On Thu, Dec 02, 2010 at 09:29:56AM +0200, Peter Ujfalusi wrote:
> > The use of DAPM widgets, and extra routing can cause ordering
> > problems in the system.
> > Machine drivers should use the exported direct interface with
> > SND_SOC_DAPM_HP's event callback to manage the state of the
> > amplifier.
>
> > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
>
> I thought we'd decided that adding a HP widget in the driver was the
> most straightforward thing here? Still...
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Applied.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
prev parent reply other threads:[~2010-12-02 11:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 7:29 [PATCH v2] ASoC: tpa6130a2: Replace DAPM code with direct interface Peter Ujfalusi
2010-12-02 9:56 ` Mark Brown
2010-12-02 10:16 ` Peter Ujfalusi
2010-12-02 11:50 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291290643.3262.47.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.