From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: Re: [PATCH 3/3] ideapad: add hotkey support Date: Thu, 02 Dec 2010 15:41:27 -0800 Message-ID: <1291333287.10586.4698.camel@nimitz> References: <1289977165-14802-1-git-send-email-ike.pan@canonical.com> <1289977238-15113-1-git-send-email-ike.pan@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ANSI_X3.4-1968" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1289977238-15113-1-git-send-email-ike.pan@canonical.com> Sender: linux-kernel-owner@vger.kernel.org To: Ike Panhc Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Matthew Garrett , David Woodhouse List-Id: platform-driver-x86.vger.kernel.org On Wed, 2010-11-17 at 15:00 +0800, Ike Panhc wrote: > +static void ideapad_input_report(unsigned long scancode) > +{ > + sparse_keymap_report_event(ideapad_priv->inputdev, scancode, 1, true); > +} I got a little build error about some unresolved symbols in the module while compiling: ERROR: "sparse_keymap_setup" [drivers/platform/x86/ideapad-laptop.ko] undefined! ERROR: "sparse_keymap_free" [drivers/platform/x86/ideapad-laptop.ko] undefined! ERROR: "sparse_keymap_report_event" [drivers/platform/x86/ideapad-laptop.ko] undefined! You can get it to go away by setting CONFIG_INPUT_SPARSEKMAP=m or =y in .config. But, I think your patches need this: diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index faec777..879d266 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -226,6 +226,7 @@ config IDEAPAD_LAPTOP tristate "Lenovo IdeaPad Laptop Extras" depends on ACPI depends on RFKILL + select INPUT_SPARSEKMAP help This is a driver for the rfkill switches on Lenovo IdeaPad netbooks. Signed-off-by: Dave Hansen