From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Subject: Re: [PATCH] ASoC: WM8580: Debug interface index Date: Fri, 03 Dec 2010 11:34:36 +0000 Message-ID: <1291376076.3271.32.camel@odin> References: <1291340065-16897-1-git-send-email-jassi.brar@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f51.google.com (mail-ww0-f51.google.com [74.125.82.51]) by alsa0.perex.cz (Postfix) with ESMTP id 4E84624477 for ; Fri, 3 Dec 2010 12:34:39 +0100 (CET) Received: by wwc33 with SMTP id 33so1120290wwc.20 for ; Fri, 03 Dec 2010 03:34:39 -0800 (PST) In-Reply-To: <1291340065-16897-1-git-send-email-jassi.brar@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Jassi Brar Cc: alsa-devel@alsa-project.org, kgene.kim@samsung.com, broonie@opensource.wolfsonmicro.com List-Id: alsa-devel@alsa-project.org On Fri, 2010-12-03 at 10:34 +0900, Jassi Brar wrote: > We want the index of DAI's driver here. > It's fine but could you add a little more context here. > Signed-off-by: Jassi Brar > --- > sound/soc/codecs/wm8580.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/sound/soc/codecs/wm8580.c b/sound/soc/codecs/wm8580.c > index e2a9276..cb7765f 100644 > --- a/sound/soc/codecs/wm8580.c > +++ b/sound/soc/codecs/wm8580.c > @@ -507,13 +507,13 @@ static int wm8580_paif_hw_params(struct snd_pcm_substream *substream, > } > > /* Look up the SYSCLK ratio; accept only exact matches */ > - ratio = wm8580->sysclk[dai->id] / params_rate(params); > + ratio = wm8580->sysclk[dai->driver->id] / params_rate(params); > for (i = 0; i < ARRAY_SIZE(wm8580_sysclk_ratios); i++) > if (ratio == wm8580_sysclk_ratios[i]) > break; > if (i == ARRAY_SIZE(wm8580_sysclk_ratios)) { > dev_err(codec->dev, "Invalid clock ratio %d/%d\n", > - wm8580->sysclk[dai->id], params_rate(params)); > + wm8580->sysclk[dai->driver->id], params_rate(params)); > return -EINVAL; > } > paifa |= i; > @@ -716,7 +716,7 @@ static int wm8580_set_sysclk(struct snd_soc_dai *dai, int clk_id, > > switch (clk_id) { > case WM8580_CLKSRC_ADCMCLK: > - if (dai->id != WM8580_DAI_PAIFTX) > + if (dai->driver->id != WM8580_DAI_PAIFTX) > return -EINVAL; > sel = 0 << sel_shift; > break; > @@ -735,7 +735,7 @@ static int wm8580_set_sysclk(struct snd_soc_dai *dai, int clk_id, > } > > /* We really should validate PLL settings but not yet */ > - wm8580->sysclk[dai->id] = freq; > + wm8580->sysclk[dai->driver->id] = freq; > > return snd_soc_update_bits(codec, WM8580_CLKSEL, sel_mask, sel); > }