Re: [PATCH 2/5] pci: MSI-X capability is 12 bytes, not 16, MSI is 10 bytes

[Alex Williamson <alex.williamson@redhat.com>]

On Fri, 2010-12-03 at 11:37 -0800, Chris Wright wrote:
> * Alex Williamson (alex.williamson@redhat.com) wrote:
> > Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> > ---
> > 
> >  hw/pci.h |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/hw/pci.h b/hw/pci.h
> > index 34955d8..7c52637 100644
> > --- a/hw/pci.h
> > +++ b/hw/pci.h
> > @@ -124,8 +124,8 @@ enum {
> >  
> >  #define PCI_CAPABILITY_CONFIG_MAX_LENGTH 0x60
> >  #define PCI_CAPABILITY_CONFIG_DEFAULT_START_ADDR 0x40
> > -#define PCI_CAPABILITY_CONFIG_MSI_LENGTH 0x10
> > -#define PCI_CAPABILITY_CONFIG_MSIX_LENGTH 0x10
> > +#define PCI_CAPABILITY_CONFIG_MSI_LENGTH 0xa
> 
> This is variable length.

Yes, but this particular #define is only used by device assignment,
which only uses the minimum sized table.  Maybe as a follow-up patch we
should just remove these from pci.h and let device-assignment keep them
private.  Thanks,

Alex