All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Sakoman <steve@sakoman.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC 1/3] tools/env: Default to the config specified in FW_CONFIG_FILE
Date: Sat, 04 Dec 2010 06:44:24 -0800	[thread overview]
Message-ID: <1291473864.23352.28.camel@quadra> (raw)
In-Reply-To: <201012040534.57622.vapier@gentoo.org>

On Sat, 2010-12-04 at 05:34 -0500, Mike Frysinger wrote:
> On Friday, December 03, 2010 23:28:51 Steve Sakoman wrote:
> > +	if (!config_file || !strlen(config_file)) {
> 
> strlen is a bad bad idea.  if you only want to see if it's non-empty, check 
> the first byte.

I'll correct this in the next revision.

Thanks for reviewing the code!

Steve

  reply	other threads:[~2010-12-04 14:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-04  4:28 [U-Boot] [RFC 0/3] Enhance env tools Steve Sakoman
2010-12-04  4:28 ` [U-Boot] [RFC 1/3] tools/env: Default to the config specified in FW_CONFIG_FILE Steve Sakoman
2010-12-04 10:34   ` Mike Frysinger
2010-12-04 14:44     ` Steve Sakoman [this message]
2010-12-04 10:59   ` Stefano Babic
2010-12-04 14:43     ` Steve Sakoman
2010-12-04  4:28 ` [U-Boot] [RFC 2/3] tools/env: Support writing to files Steve Sakoman
2010-12-04 10:37   ` Mike Frysinger
2010-12-04 14:42     ` Steve Sakoman
2010-12-04 11:23   ` Stefano Babic
2010-12-04 14:48     ` Steve Sakoman
2010-12-05  0:05       ` Loïc Minier
2010-12-04  4:28 ` [U-Boot] [RFC 3/3] tools/env: Bump devname length to PATH_MAX for filenames Steve Sakoman
2010-12-04 20:35 ` [U-Boot] [RFC 0/3] Enhance env tools Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291473864.23352.28.camel@quadra \
    --to=steve@sakoman.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.