From: Ben Hutchings <benh@debian.org>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Hayes Wang <hayeswang@realtek.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/r8169: Remove the firmware of RTL8111D
Date: Mon, 06 Dec 2010 04:38:04 +0000 [thread overview]
Message-ID: <1291610284.8025.154.camel@localhost> (raw)
In-Reply-To: <20101201080732.GA3234@electric-eye.fr.zoreil.com>
[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]
On Wed, 2010-12-01 at 09:07 +0100, Francois Romieu wrote:
> Hayes Wang <hayeswang@realtek.com> :
> > Remove the firmware of RTL8111D from the kernel.
> > The binary file of firmware would be moved to linux-firmware repository.
>
> The driver can not simply go along when request_firmware fails. Though Ben's
> code did not take care of it, the driver should imho propagate some return
> code. Ben ?
[...]
Sorry I haven't been more responsive on this.
I have reports that the RTL8111D/8168D hardware can work without this
firmware, possibly with limited functionality or compatibility. (I
assume it is a patch for the original firmware loaded from ROM or
flash.) So I feel obliged to give users the choice to use the driver
without installing non-free firmware. If you want to make the warning
on failure of request_firmware() more explicit then that's OK with me.
If you make the failure fatal I will probably revert that in Debian.
Ben.
--
Ben Hutchings, Debian Developer and kernel team member
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2010-12-06 4:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 5:22 [PATCH] net/r8169: Remove the firmware of RTL8111D Hayes Wang
2010-12-01 8:07 ` Francois Romieu
2010-12-01 9:54 ` hayeswang
2010-12-01 16:36 ` Stefan Lippers-Hollmann
2010-12-01 17:05 ` Ben Hutchings
2010-12-01 22:40 ` Francois Romieu
2010-12-06 4:38 ` Ben Hutchings [this message]
2010-12-06 22:04 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291610284.8025.154.camel@localhost \
--to=benh@debian.org \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.