From: Anders Kaseorg <andersk@MIT.EDU>
To: "Diego Elio Pettenò" <flameeyes@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] imap-send: link against libcrypto for HMAC and others
Date: Mon, 06 Dec 2010 00:28:24 -0500 [thread overview]
Message-ID: <1291613304.3339.12.camel@fixed-disk> (raw)
In-Reply-To: <1290629033-20566-1-git-send-email-flameeyes@gmail.com>
On Wed, 2010-11-24 at 21:03 +0100, Diego Elio Pettenò wrote:
> When using stricter linkers, such as GNU gold or Darwin ld, transitive
> dependencies are not counted towards symbol resolution. If we don't
> link imap-send to libcrypto, we'll have undefined references to the
> HMAC_*, EVP_* and ERR_* functions families.
> […]
> git-imap-send$X: imap-send.o $(GITLIBS)
> $(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
> - $(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL)
> + $(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL) $(LIB_4_CRYPTO)
This broke the build with NO_OPENSSL=1, so Debian will need to revert
it:
CC imap-send.o
LINK git-imap-send
/usr/bin/ld: cannot find -lcrypto
collect2: ld returned 1 exit status
make[1]: *** [git-imap-send] Error 1
Also, the Makefile already has a NEEDS_CRYPTO_WITH_SSL flag that’s
automatically set on Darwin, Windows, and MinGW. We shouldn’t have two
mechanisms for addressing the same problem; maybe we just need to enable
the existing flag on more (or all) platforms?
Anders
next prev parent reply other threads:[~2010-12-06 5:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 13:55 [PATCH] imap-send: link against libcrypto for HMAC and others Diego Elio Pettenò
2010-11-24 20:01 ` Junio C Hamano
2010-11-24 20:03 ` Diego Elio Pettenò
2010-12-06 5:28 ` Anders Kaseorg [this message]
2010-12-06 5:39 ` Diego Elio Pettenò
2010-12-06 6:06 ` Jonathan Nieder
2010-12-06 6:11 ` Junio C Hamano
2010-12-08 1:51 ` Jared Hance
2010-12-08 2:12 ` Junio C Hamano
2010-12-08 4:53 ` Anders Kaseorg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291613304.3339.12.camel@fixed-disk \
--to=andersk@mit.edu \
--cc=flameeyes@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.