From: Daniel Walker <dwalker@codeaurora.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Brandon Leong <bleong@codeaurora.org>,
lrg@slimlogic.co.uk, davidb@codeaurora.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] regulator: debugfs: Adding debugfs functions into regulator framework
Date: Mon, 06 Dec 2010 18:52:00 -0800 [thread overview]
Message-ID: <1291690320.4150.1.camel@m0nster> (raw)
In-Reply-To: <20101206222907.GA2425@opensource.wolfsonmicro.com>
On Mon, 2010-12-06 at 22:29 +0000, Mark Brown wrote:
> > +static int reg_debug_enable_set(void *data, u64 val)
> > +{
> > + int err_info;
> > + if (IS_ERR(data) || data == NULL) {
> > + pr_err("Function Input Error %ld\n", PTR_ERR(data));
>
> Please Try To Make Your Log Messages A Bit More Descriptive And
> Typographically Correct - I'd not expect a user to have a hope of
> figuring out what's gone wrong here. That said, I suspect you're
> looking for BUG_ON() here...
Could we do WARN_ON() here? Unless this is a really serious problem.
Daniel
--
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum.
next prev parent reply other threads:[~2010-12-07 2:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 20:52 [PATCH] regulator: debugfs: Adding debugfs functions into regulator framework Brandon Leong
2010-12-06 22:29 ` Mark Brown
2010-12-07 2:52 ` Daniel Walker [this message]
2010-12-07 11:57 ` Mark Brown
2010-12-07 22:04 ` Brandon Leong
2010-12-07 22:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291690320.4150.1.camel@m0nster \
--to=dwalker@codeaurora.org \
--cc=bleong@codeaurora.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=davidb@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.