From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Subject: Re: [PATCH] ASoC: dapm: Add speaker driver widget. Date: Tue, 07 Dec 2010 12:34:45 +0000 Message-ID: <1291725285.3275.14.camel@odin> References: <1889FA7136B567478A67D4B0F85B0CCEA4C52E7E@dlee06.ent.ti.com> <20101206224359.GB2862@opensource.wolfsonmicro.com> <1291676132.3281.116.camel@odin> <20101206230948.GH2862@opensource.wolfsonmicro.com> <1291678207.3281.152.camel@odin> (sfid-20101206_233011_917022_3EC062E3) <8C6859A9-36EF-4016-822B-DA67D7147E28@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wy0-f179.google.com (mail-wy0-f179.google.com [74.125.82.179]) by alsa0.perex.cz (Postfix) with ESMTP id 7161910380F for ; Tue, 7 Dec 2010 13:34:49 +0100 (CET) Received: by wyi11 with SMTP id 11so13314693wyi.38 for ; Tue, 07 Dec 2010 04:34:48 -0800 (PST) In-Reply-To: <8C6859A9-36EF-4016-822B-DA67D7147E28@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: "Olaya, Margarita" , "alsa-devel@alsa-project.org" List-Id: alsa-devel@alsa-project.org On Mon, 2010-12-06 at 23:38 +0000, Mark Brown wrote: > On 6 Dec 2010, at 23:30, Liam Girdwood wrote: > > On Mon, 2010-12-06 at 23:09 +0000, Mark Brown wrote: > >> > > >> Sure, but it's fulfiling the same role in the system - it's just that > >> these days a lot more CODECs are pulling speaker drivers directly into > >> the CODEC die. Mostly these have worked well handled as PGAs so it's > >> not been an issue. > > > In this case as we need to enable the PGA before the driver and disable > > the driver before the PGA for pop reduction. Hence the current ordering > > needs an addition/refactoring to deal with the newer generation of > > CODECs here. > > Well, what I'm saying is that... > > >> I'd certainly expect to see it handled the same way from a DAPM > >> sequencing point of view as it's fulfilling the same role in the system > >> (so in the same slot rather than separately as the patch was doing). Do > >> we just need to refactor the existing external widgets to be able to > >> exist in either register or GPIO based versions? > > ...we don't need to change the ordering at all, we've already got a > sequence point for this sort of widget we can use. We should just make > the existing speaker and headphone widgets be in terms of one, I think. > The only minor problem here is that the current sequence point is name "snd_soc_dapm_spk" which would seem confusing to haptic/vibra driver users. Although, I can live with this.... Liam