From: Namhyung Kim <namhyung@gmail.com>
To: James Bottomley <James.Bottomley@suse.de>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Adaptec OEM Raid Solutions <aacraid@adaptec.com>
Subject: Re: [PATCH 1/3] [SCSI] dpt_i2o: fix compiler warning on dptids
Date: Wed, 08 Dec 2010 01:12:28 +0900 [thread overview]
Message-ID: <1291738348.1638.9.camel@leonhard> (raw)
In-Reply-To: <1291737421.17668.5.camel@mulgrave.site>
2010-12-07 (화), 09:57 -0600, James Bottomley:
> Um so this is definitely used in the MODULE_DEVICE_TABLE just below.
>
> I deduce you have some type of config which causes that to be a nop
> (say !CONFIG_MODULE)? In which case, surely the correct fix is in
> module.h?
>
Hi,
MODULE_DEVICE_TABLE expands to nop when !MODULE (not !CONFIG_MODULE) so
allyesconfig build always emits the warnings. Possible patch for this
would be wraping it up in #ifdefs but when I sent a same patch to Greg
KH he didn't want to add more #ifdefs in .c files.
--
Regards,
Namhyung Kim
next prev parent reply other threads:[~2010-12-07 16:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 15:31 [PATCH 1/3] [SCSI] dpt_i2o: fix compiler warning on dptids Namhyung Kim
2010-12-07 15:31 ` [PATCH 2/3] [SCSI] fdomain: fix compiler warning on fdomain_pci_tbl Namhyung Kim
2010-12-07 15:31 ` [PATCH 3/3] [SCSI] initio: fix compiler warning on i91u_pci_devices Namhyung Kim
2010-12-07 15:57 ` [PATCH 1/3] [SCSI] dpt_i2o: fix compiler warning on dptids James Bottomley
2010-12-07 16:12 ` Namhyung Kim [this message]
2010-12-07 16:30 ` James Bottomley
2010-12-07 17:24 ` Namhyung Kim
2010-12-07 17:24 ` Namhyung Kim
2010-12-08 16:20 ` Namhyung Kim
2010-12-08 16:24 ` James Bottomley
2010-12-08 16:24 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291738348.1638.9.camel@leonhard \
--to=namhyung@gmail.com \
--cc=James.Bottomley@suse.de \
--cc=aacraid@adaptec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.