All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Martin Steigerwald <Martin@lichtvoll.de>,
	linux-kernel@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: bugs/regressions: report in LKML or in bugzilla?
Date: Tue, 07 Dec 2010 21:02:56 +0000	[thread overview]
Message-ID: <1291755776.21627.13.camel@bwh-desktop> (raw)
In-Reply-To: <1291738321.2695.338.camel@edumazet-laptop>

On Tue, 2010-12-07 at 17:12 +0100, Eric Dumazet wrote:
> Le mardi 07 décembre 2010 à 16:39 +0100, Martin Steigerwald a écrit :
> 
> > A participant of a linux performance training I hold found a bug with 
> > window scaling which did not receive any reply as well:
> > 
> > Bug 20312 -  System freeze with multiples of 32 in 
> > /proc/sys/net/ipv4/tcp_adv_win_scale
> > https://bugzilla.kernel.org/show_bug.cgi?id=20312
> > 
> 
> User bug ?
> 
> Documentation/networking/ip-sysctl.txt
> 
> tcp_adv_win_scale - INTEGER
> 	Count buffering overhead as bytes/2^tcp_adv_win_scale 
> 	(if tcp_adv_win_scale > 0) or bytes-bytes/2^(-tcp_adv_win_scale),
> 	if it is <= 0.
> 	Default: 2
> 
> Given we use 32bit numbers, using values outside of [-31 ... 31] makes litle sense.
> 
> We could add sysctl range limit, but user should not mess with 
> /proc/sys/net/ipv4/parameters unless he knows what he is doing ?
[...]

For mere humans, the range is not quite os obvious.  Which is why this
has been fixed in net-2.6 (as noted on that bug report now).

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.


  reply	other threads:[~2010-12-07 21:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-07 15:39 bugs/regressions: report in LKML or in bugzilla? Martin Steigerwald
2010-12-07 16:12 ` Eric Dumazet
2010-12-07 21:02   ` Ben Hutchings [this message]
2010-12-07 21:28     ` [PATCH] tcp: avoid a possible divide by zero Eric Dumazet
2010-12-07 21:32       ` Ben Hutchings
2010-12-07 22:03         ` Eric Dumazet
2010-12-08  8:23           ` Martin Steigerwald
2010-12-08  8:33             ` Eric Dumazet
2010-12-08 20:35           ` David Miller
2010-12-07 22:20       ` [PATCH] tcp: protect sysctl_tcp_cookie_size reads Eric Dumazet
2010-12-08 20:35         ` David Miller
2010-12-07 21:28     ` bugs/regressions: report in LKML or in bugzilla? Martin Steigerwald
2010-12-07 21:11   ` Martin Steigerwald
2010-12-07 17:41 ` Randy Dunlap
2010-12-07 21:04   ` Martin Steigerwald
2010-12-08 10:00     ` Florian Mickler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291755776.21627.13.camel@bwh-desktop \
    --to=bhutchings@solarflare.com \
    --cc=Martin@lichtvoll.de \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.