From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 3/4] isimodem2.5: Changes to add isimodem2.5
Date: Wed, 08 Dec 2010 10:30:04 +0100 [thread overview]
Message-ID: <1291800604.4795.151.camel@aeonflux> (raw)
In-Reply-To: <1291797294-20554-1-git-send-email-jessica.j.nilsson@stericsson.com>
[-- Attachment #1: Type: text/plain, Size: 4339 bytes --]
Hi Jessica,
> Updates in Makefile.am - adding of isimodem2.5
> Adding of drivers/isimodem2.5/ files to fully listed functionality.
>
> Regards,
> Jessica Nilsson
>
> ---
> Makefile.am | 36 +-
> drivers/isimodem2.5/call-barring.c | 503 ++
> drivers/isimodem2.5/call-forwarding.c | 613 +++
> drivers/isimodem2.5/call-settings.c | 1093 +++++
> drivers/isimodem2.5/call.h | 237 +
> drivers/isimodem2.5/cbs.c | 433 ++
> drivers/isimodem2.5/checkpatch.pl | 2789 ++++++++++++
> drivers/isimodem2.5/debug.c | 694 +++
> drivers/isimodem2.5/debug.h | 66 +
> drivers/isimodem2.5/devinfo.c | 246 +
> drivers/isimodem2.5/gpds-context.c | 788 ++++
> drivers/isimodem2.5/gpds.c | 395 ++
> drivers/isimodem2.5/gpds.h | 295 ++
> drivers/isimodem2.5/gss.h | 84 +
> drivers/isimodem2.5/info.h | 53 +
> drivers/isimodem2.5/isimodem.c | 534 +++
> drivers/isimodem2.5/isimodem.h | 69 +
> drivers/isimodem2.5/isiutil.h | 64 +
> drivers/isimodem2.5/mce.h | 65 +
> drivers/isimodem2.5/network-registration.c | 1158 +++++
> drivers/isimodem2.5/network.h | 257 ++
> drivers/isimodem2.5/phonebook.c | 1320 ++++++
> drivers/isimodem2.5/radio-settings.c | 313 ++
> drivers/isimodem2.5/simu_resps.h | 6800 ++++++++++++++++++++++++++++
> drivers/isimodem2.5/sms.c | 869 ++++
> drivers/isimodem2.5/sms.h | 188 +
> drivers/isimodem2.5/ss.h | 174 +
> drivers/isimodem2.5/ssn.c | 456 ++
> drivers/isimodem2.5/timeout.h | 33 +
> drivers/isimodem2.5/uicc.c | 3316 ++++++++++++++
> drivers/isimodem2.5/uicc.h | 253 ++
> drivers/isimodem2.5/uicc_interface.h | 40 +
> drivers/isimodem2.5/ussd.c | 341 ++
> drivers/isimodem2.5/voicecall.c | 1555 +++++++
> 34 files changed, 26128 insertions(+), 2 deletions(-)
> create mode 100644 drivers/isimodem2.5/call-barring.c
> create mode 100644 drivers/isimodem2.5/call-forwarding.c
> create mode 100644 drivers/isimodem2.5/call-settings.c
> create mode 100644 drivers/isimodem2.5/call.h
> create mode 100644 drivers/isimodem2.5/cbs.c
> create mode 100755 drivers/isimodem2.5/checkpatch.pl
> create mode 100644 drivers/isimodem2.5/debug.c
> create mode 100644 drivers/isimodem2.5/debug.h
> create mode 100644 drivers/isimodem2.5/devinfo.c
> create mode 100644 drivers/isimodem2.5/gpds-context.c
> create mode 100644 drivers/isimodem2.5/gpds.c
> create mode 100644 drivers/isimodem2.5/gpds.h
> create mode 100644 drivers/isimodem2.5/gss.h
> create mode 100644 drivers/isimodem2.5/info.h
> create mode 100644 drivers/isimodem2.5/isimodem.c
> create mode 100644 drivers/isimodem2.5/isimodem.h
> create mode 100644 drivers/isimodem2.5/isiutil.h
> create mode 100644 drivers/isimodem2.5/mce.h
> create mode 100644 drivers/isimodem2.5/network-registration.c
> create mode 100644 drivers/isimodem2.5/network.h
> create mode 100644 drivers/isimodem2.5/phonebook.c
> create mode 100644 drivers/isimodem2.5/radio-settings.c
> create mode 100644 drivers/isimodem2.5/simu_resps.h
> create mode 100644 drivers/isimodem2.5/sms.c
> create mode 100644 drivers/isimodem2.5/sms.h
> create mode 100644 drivers/isimodem2.5/ss.h
> create mode 100644 drivers/isimodem2.5/ssn.c
> create mode 100644 drivers/isimodem2.5/timeout.h
> create mode 100644 drivers/isimodem2.5/uicc.c
> create mode 100644 drivers/isimodem2.5/uicc.h
> create mode 100644 drivers/isimodem2.5/uicc_interface.h
> create mode 100644 drivers/isimodem2.5/ussd.c
> create mode 100644 drivers/isimodem2.5/voicecall.c
this is not gonna work this way. No one can review such a massive patch.
Actually Evolution even refused to format this for me.
So please split this into one patch per atom driver.
In addition, I don't a point in a filename. So isimodem25 or isimodem2
or something like that please. I am open for proposals.
Regards
Marcel
next prev parent reply other threads:[~2010-12-08 9:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 8:34 [PATCH 3/4] isimodem2.5: Changes to add isimodem2.5 Jessica Nilsson
2010-12-08 9:30 ` Marcel Holtmann [this message]
2010-12-08 13:25 ` Jessica Nilsson
2010-12-08 13:42 ` Mika.Liljeberg
2010-12-08 15:19 ` Marcel Holtmann
2010-12-09 8:45 ` Jessica Nilsson
2010-12-09 6:26 ` Aki Niemi
2010-12-09 11:36 ` Jessica Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291800604.4795.151.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.