All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aki Niemi <aki.niemi@nokia.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/4] gisi: Changes to prepare for isimodem2.5
Date: Wed, 08 Dec 2010 16:32:31 +0200	[thread overview]
Message-ID: <1291818751.25976.173.camel@tucson> (raw)
In-Reply-To: <4CFF8586.1060000@stericsson.com>

[-- Attachment #1: Type: text/plain, Size: 577 bytes --]

Hi,

On Wed, 2010-12-08 at 14:17 +0100, ext Jessica Nilsson wrote:
> > Also is this in sync with the GISI re-write Aki is doing?
> thank you for your comments.
> We are studying what Aki is doing and are in contact with him and will 
> get back to this.

One item I can see is missing is the ability to set the remote spn_dev
and spn_obj for GIsiPipe and GIsiModem. For the N900 modem, these both
default to zero, but are something different for the STE modem.

We should simply create new constructors that let these be set to
non-zero values.

Cheers,
Aki


      reply	other threads:[~2010-12-08 14:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-08  8:34 [PATCH 1/4] gisi: Changes to prepare for isimodem2.5 Jessica Nilsson
2010-12-08  9:31 ` Marcel Holtmann
2010-12-08 13:17   ` Jessica Nilsson
2010-12-08 14:32     ` Aki Niemi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291818751.25976.173.camel@tucson \
    --to=aki.niemi@nokia.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.