From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Airlie Subject: Re: [PATCH] drm/kms: remove spaces from connector names Date: Thu, 09 Dec 2010 10:01:01 +1000 Message-ID: <1291852861.3725.89.camel@clockmaker-el6> References: <1291850043-7742-1-git-send-email-alexdeucher@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTP id F1ADB9E744 for ; Wed, 8 Dec 2010 16:01:40 -0800 (PST) In-Reply-To: <1291850043-7742-1-git-send-email-alexdeucher@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Alex Deucher Cc: Sergej Pupykin , dri-devel@lists.freedesktop.org, stable@kernel.org List-Id: dri-devel@lists.freedesktop.org On Wed, 2010-12-08 at 18:14 -0500, Alex Deucher wrote: > Grub doesn't parse spaces in parameters correctly, so > this makes it impossible to force video= parameters > for kms on the grub kernel command line. I'm sorta tempted to just go the extra step towards DIN, HDMIA, HDMIB, DP and eDP, typing long names on the command line isn't fun. Dave. > > Reported-by: Sergej Pupykin > > Cc: Sergej Pupykin > Signed-off-by: Alex Deucher > Cc: stable@kernel.org > --- > drivers/gpu/drm/drm_crtc.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index 6985cb1..7ee7a2f 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -156,12 +156,12 @@ static struct drm_conn_prop_enum_list drm_connector_enum_list[] = > { DRM_MODE_CONNECTOR_SVIDEO, "SVIDEO", 0 }, > { DRM_MODE_CONNECTOR_LVDS, "LVDS", 0 }, > { DRM_MODE_CONNECTOR_Component, "Component", 0 }, > - { DRM_MODE_CONNECTOR_9PinDIN, "9-pin DIN", 0 }, > + { DRM_MODE_CONNECTOR_9PinDIN, "9-pin_DIN", 0 }, > { DRM_MODE_CONNECTOR_DisplayPort, "DisplayPort", 0 }, > - { DRM_MODE_CONNECTOR_HDMIA, "HDMI Type A", 0 }, > - { DRM_MODE_CONNECTOR_HDMIB, "HDMI Type B", 0 }, > + { DRM_MODE_CONNECTOR_HDMIA, "HDMI_Type_A", 0 }, > + { DRM_MODE_CONNECTOR_HDMIB, "HDMI_Type_B", 0 }, > { DRM_MODE_CONNECTOR_TV, "TV", 0 }, > - { DRM_MODE_CONNECTOR_eDP, "Embedded DisplayPort", 0 }, > + { DRM_MODE_CONNECTOR_eDP, "Embedded_DisplayPort", 0 }, > }; > > static struct drm_prop_enum_list drm_encoder_enum_list[] =