From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gianni Tedesco <gianni.tedesco@citrix.com>
Subject: Re: [PATCH 1 of 5] Support getting topology info in libxl
Date: Thu, 9 Dec 2010 13:11:48 +0000
Message-ID: <1291900308.20366.1.camel@qabil.uk.xensource.com>
References: <a1eb18bec4690b6687bc.1291898377@nehalem1>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <a1eb18bec4690b6687bc.1291898377@nehalem1>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Juergen Gross <juergen.gross@ts.fujitsu.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2010-12-09 at 12:39 +0000, Juergen Gross wrote:
> 
> +PyObject *attrib__libxl_cpuarray_get(libxl_cpuarray *pptr)
> +{
> +    PyObject *list = NULL;
> +    int i;
> +
> +    list = PyList_New(0);
> +    for (i = 0; i < pptr->entries; i++) {
> +        if (pptr->array[i] == LIBXL_CPUARRAY_INVALID_ENTRY) {
> +            PyList_Append(list, Py_None);
> +            Py_INCREF(Py_None); 


Actually I think I am the one who is confused. It is the other way
around. I need to fix other places that leak references due to this.

IOW, this was good to go first time around, tried to respond earlier but
my mail client barfed the message.

Sorry for the noise! :(

Gianni