From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: branto@redhat.com, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: fix 108 golden output
Date: Thu, 09 Dec 2010 15:19:39 -0600 [thread overview]
Message-ID: <1291929579.13355.30.camel@doink> (raw)
In-Reply-To: <20101110125855.GA18357@infradead.org>
On Wed, 2010-11-10 at 07:58 -0500, Christoph Hellwig wrote:
> The new common scratch mount filter produces slightly different
> whitespaces than the old home grown filter, so adjust the golden
> output.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
I found out why this is happening. I get no
such error, and Dave Chinner said he wasn't seeing
it either.
xfs_quota is formatting its output such that the
second and later columns always align at a certain
offset from the beginning of the line. As a result,
path names assigned as SCRATCH_DEV of different
lengths will produce different (filtered) output,
with more or fewer blanks between SCRATCH_DEV and
the usage number.
Boris Ranto has proposed a change that would
add the "-b" flag to diff when checking output
against golden output. That should fix it, but
it's possible we *want* differences in white
space to matter in some cases. Have to look
into this.
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-12-09 21:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 12:58 [PATCH] xfstests: fix 108 golden output Christoph Hellwig
2010-11-17 9:17 ` Christoph Hellwig
2010-11-18 5:44 ` Dave Chinner
2010-12-09 21:19 ` Alex Elder [this message]
2010-12-10 10:06 ` Boris Ranto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291929579.13355.30.camel@doink \
--to=aelder@sgi.com \
--cc=branto@redhat.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.