Re: [*v2 PATCH 01/22] IPVS: netns, add basic init per netns.

[Hans Schillstrom <hans.schillstrom@ericsson.com>]

On Mon, 2010-12-13 at 15:08 +0100, Jan Engelhardt wrote:
> On Monday 2010-12-13 14:38, Hans Schillstrom wrote:
> >@@ -28,6 +28,18 @@
> > #if defined(CONFIG_NF_CONNTRACK) || defined(CONFIG_NF_CONNTRACK_MODULE)
> > #include <net/netfilter/nf_conntrack.h>
> > #endif
> >+#include <net/net_namespace.h>		/* Netw namespace */
> >+
> >+/*
> >+ * Generic access of ipvs struct
> >+ */
> >+static inline struct netns_ipvs * net_ipvs(struct net* net) {
> >+#ifdef CONFIG_NET_NS
> >+	return net->ipvs;
> >+#else
> >+	return init_net.ipvs;
> >+#endif
> >+}
> 
> This looks redundant, because even in the !CONFIG_NET_NS case,
> 'net' is valid and already points to &init_net.

Yes, that's right I'll remove it.

Thanks
Hans
> 
> >+static void __net_exit __ip_vs_cleanup(struct net *net)
> >+{
> >+	struct netns_ipvs *ipvs = net_ipvs(net);
> >+
> >+	IP_VS_DBG(10, "ipvs netns %d released\n", ipvs->inc);
> >+}
> >+