From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=53659 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PSChb-0005kM-L8
	for qemu-devel@nongnu.org; Mon, 13 Dec 2010 13:00:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1PSCha-0000qx-HA
	for qemu-devel@nongnu.org; Mon, 13 Dec 2010 13:00:47 -0500
Received: from mx1.redhat.com ([209.132.183.28]:3101)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1PSCha-0000qo-AU
	for qemu-devel@nongnu.org; Mon, 13 Dec 2010 13:00:46 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oBDI0jJR003805
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 13 Dec 2010 13:00:45 -0500
From: Alex Williamson <alex.williamson@redhat.com>
In-Reply-To: <20101213175010.GD7182@redhat.com>
References: <20101209191623.15450.19696.stgit@s20.home>
	<m3k4jihb1u.fsf@trasno.mitica> <1291932857.2926.20.camel@x201>
	<20101212102812.GA13033@redhat.com> <m3ipyzw6kc.fsf@trasno.org>
	<20101212120120.GA15016@redhat.com> <m3ei9nvyzc.fsf@trasno.org>
	<1292171345.2857.43.camel@x201> <m3tyiiu1jj.fsf@trasno.org>
	<1292262202.2857.114.camel@x201>  <20101213175010.GD7182@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Date: Mon, 13 Dec 2010 11:00:44 -0700
Message-ID: <1292263244.2857.120.camel@x201>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com

On Mon, 2010-12-13 at 19:50 +0200, Michael S. Tsirkin wrote:
> On Mon, Dec 13, 2010 at 10:43:22AM -0700, Alex Williamson wrote:
> > So, unfortunately, I stand by my original patch.
> 
> What about the one that put -1 in saved index for a hotplugged device?

There are still examples that don't work even without hotplug (example 2
and example 3 after the reboot).  That hack limits the damage, but still
leaves a latent bug for reboot and doesn't address the non-hotplug
scenarios.  So, I don't think it's worthwhile to pursue, and we
shouldn't pretend we can use it to avoid bumping the version_id.
Thanks,

Alex