Re: [PATCH 3/5] pci-assign: Remove suspicious hunk from assigned_dev_pci_read_config

[Alex Williamson <alex.williamson@redhat.com>]

On Tue, 2010-12-14 at 00:25 +0100, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> No one can remember where this came from, and it looks very hacky
> anyway (we return 0 for config space address 0xfc of _every_ assigned
> device, not only vga as the comment claims). So better remove it and
> wait for the underlying issue to reappear.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  hw/device-assignment.c |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)

Yay!

Acked-by: Alex Williamson <alex.williamson@redhat.com>

> diff --git a/hw/device-assignment.c b/hw/device-assignment.c
> index 6ff1456..ef045f4 100644
> --- a/hw/device-assignment.c
> +++ b/hw/device-assignment.c
> @@ -508,10 +508,6 @@ static uint32_t assigned_dev_pci_read_config(PCIDevice *d, uint32_t address,
>          return val;
>      }
>  
> -    /* vga specific, remove later */
> -    if (address == 0xFC)
> -        goto do_log;
> -
>      fd = pci_dev->real_device.config_fd;
>  
>  again:
> @@ -526,7 +522,6 @@ again:
>  	exit(1);
>      }
>  
> -do_log:
>      DEBUG("(%x.%x): address=%04x val=0x%08x len=%d\n",
>            (d->devfn >> 3) & 0x1F, (d->devfn & 0x7), address, val, len);
>