Re: [PATCH 9/9] ed: Change bin path

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Tue, 2010-12-14 at 16:58 +0800, Lu Jingdong wrote:
> Subject: [PATCH 9/9] ed: Change bin path
> 
> Change bin path of ed from usr/bin into bin for LSB.
> 
> Signed-off-by: Jingdong Lu <jingdong.lu@windriver.com>
> ---
>  meta/recipes-extended/ed/ed_1.5.bb |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-extended/ed/ed_1.5.bb
> b/meta/recipes-extended/ed/ed_1.5.bb
> index 2242ffa..a609f42 100644
> --- a/meta/recipes-extended/ed/ed_1.5.bb
> +++ b/meta/recipes-extended/ed/ed_1.5.bb
> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=f27defe1e96c2e1ecd4e0c9be8967949 \
> 
> file://main.c;endline=24;md5=177fe82d0649e545591a13fdce5733e8"
> 
>  SECTION = "base"
> -PR = "r0"
> +PR = "r1"
> 
>  SRC_URI = "${GNU_MIRROR}/ed/ed-${PV}.tar.gz \
>             file://ed-1.2-build.patch"
> @@ -18,5 +18,5 @@ do_configure() {
>  }
> 
>  do_install() {
> -       oe_runmake 'DESTDIR=${D}' install
> +       oe_runmake 'DESTDIR=${D}' bindir=/bin install
>  }

This at the very least needs a strong comment about why we're doing
this.

I'd suggest adding something like to the recipe instead:

# LSB states that ed should be in /bin/
bindir = "${base_bindir}"

Cheers,

Richard