All of lore.kernel.org
 help / color / mirror / Atom feed
From: peterz@infradead.org (Peter Zijlstra)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] sched: Fix the irqtime code to deal with u64 wraps
Date: Wed, 15 Dec 2010 19:24:12 +0100	[thread overview]
Message-ID: <1292437452.2708.45.camel@laptop> (raw)
In-Reply-To: <AANLkTin86W-W69fGpj+5LCP7L-KQfA_tn506o+RZ_UED@mail.gmail.com>

On Wed, 2010-12-15 at 10:16 -0800, Venkatesh Pallipadi wrote:
> Peter,
> 
> This looks like something that happened while splitting this into two
> patches. I needed a trivial change like below before I could apply
> these two patches on linus-git.
> 
> Thanks,
> Venki
> ---
> @@ -641,17 +641,18 @@ static void sched_irq_time_avg_update(struct rq
> *rq, u64 irq_time);
> 
>  inline void update_rq_clock(struct rq *rq)
>  {
> -	if (!rq->skip_clock_update) {
> -		int cpu = cpu_of(rq);
> -		u64 irq_time;
> +	int cpu = cpu_of(rq);
> +	u64 irq_time;
> 
> -		rq->clock = sched_clock_cpu(cpu);
> -		irq_time = irq_time_cpu(cpu);
> -		if (rq->clock - irq_time > rq->clock_task)
> -			rq->clock_task = rq->clock - irq_time;
> +	if (rq->skip_clock_update)
> +		return;
> 
> -		sched_irq_time_avg_update(rq, irq_time);
> -	}
> +	rq->clock = sched_clock_cpu(cpu);
> +	irq_time = irq_time_cpu(cpu);
> +	if (rq->clock - irq_time > rq->clock_task)
> +		rq->clock_task = rq->clock - irq_time;
> +
> +	sched_irq_time_avg_update(rq, irq_time);
>  }
> 
>  /*


That's due another patch in tip/sched/urgent

WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Venkatesh Pallipadi <venki@google.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Mikael Pettersson <mikpe@it.uu.se>, Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	John Stultz <johnstul@us.ibm.com>,
	Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [PATCH 1/2] sched: Fix the irqtime code to deal with u64 wraps
Date: Wed, 15 Dec 2010 19:24:12 +0100	[thread overview]
Message-ID: <1292437452.2708.45.camel@laptop> (raw)
In-Reply-To: <AANLkTin86W-W69fGpj+5LCP7L-KQfA_tn506o+RZ_UED@mail.gmail.com>

On Wed, 2010-12-15 at 10:16 -0800, Venkatesh Pallipadi wrote:
> Peter,
> 
> This looks like something that happened while splitting this into two
> patches. I needed a trivial change like below before I could apply
> these two patches on linus-git.
> 
> Thanks,
> Venki
> ---
> @@ -641,17 +641,18 @@ static void sched_irq_time_avg_update(struct rq
> *rq, u64 irq_time);
> 
>  inline void update_rq_clock(struct rq *rq)
>  {
> -	if (!rq->skip_clock_update) {
> -		int cpu = cpu_of(rq);
> -		u64 irq_time;
> +	int cpu = cpu_of(rq);
> +	u64 irq_time;
> 
> -		rq->clock = sched_clock_cpu(cpu);
> -		irq_time = irq_time_cpu(cpu);
> -		if (rq->clock - irq_time > rq->clock_task)
> -			rq->clock_task = rq->clock - irq_time;
> +	if (rq->skip_clock_update)
> +		return;
> 
> -		sched_irq_time_avg_update(rq, irq_time);
> -	}
> +	rq->clock = sched_clock_cpu(cpu);
> +	irq_time = irq_time_cpu(cpu);
> +	if (rq->clock - irq_time > rq->clock_task)
> +		rq->clock_task = rq->clock - irq_time;
> +
> +	sched_irq_time_avg_update(rq, irq_time);
>  }
> 
>  /*


That's due another patch in tip/sched/urgent



  reply	other threads:[~2010-12-15 18:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-10 20:38 [PATCH] sched: Fix the irqtime code to deal with u64 wraps Peter Zijlstra
2010-12-10 20:38 ` Peter Zijlstra
2010-12-10 22:09 ` Venkatesh Pallipadi
2010-12-10 22:09   ` Venkatesh Pallipadi
2010-12-13 12:13   ` [PATCH 1/2] " Peter Zijlstra
2010-12-13 12:13     ` Peter Zijlstra
2010-12-15 18:16     ` Venkatesh Pallipadi
2010-12-15 18:16       ` Venkatesh Pallipadi
2010-12-15 18:24       ` Peter Zijlstra [this message]
2010-12-15 18:24         ` Peter Zijlstra
2010-12-16 12:31     ` [tip:sched/urgent] " tip-bot for Peter Zijlstra
2010-12-13 12:13   ` [PATCH 2/2] sched: Fix the irqtime code for 32bit Peter Zijlstra
2010-12-13 12:13     ` Peter Zijlstra
2010-12-16 12:31     ` [tip:sched/urgent] " tip-bot for Peter Zijlstra
2010-12-11  2:23 ` [PATCH] sched: Fix the irqtime code to deal with u64 wraps Nicolas Pitre
2010-12-11  2:23   ` Nicolas Pitre
2010-12-11  9:55   ` Peter Zijlstra
2010-12-12 13:03 ` Mikael Pettersson
2010-12-12 13:03   ` Mikael Pettersson
  -- strict thread matches above, loose matches on Subject: below --
2010-12-15  1:07 [PATCH 1/2] " Daniel Kopko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1292437452.2708.45.camel@laptop \
    --to=peterz@infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.