From: Stefani Seibold <stefani@seibold.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Pekka Enberg <penberg@kernel.org>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] cramfs: generate unique inode number for better inode cache usage
Date: Thu, 16 Dec 2010 10:47:22 +0100 [thread overview]
Message-ID: <1292492842.3019.5.camel@wall-e> (raw)
In-Reply-To: <AANLkTi=6LPBAFu6r75RSYjndCk_P9tDH=bavO3j4c1Rq@mail.gmail.com>
Am Mittwoch, den 15.12.2010, 08:45 -0800 schrieb Linus Torvalds:
> On Wed, Dec 15, 2010 at 8:31 AM, <stefani@seibold.net> wrote:
> >
> > Pekka's approach is not problem. But the "cruddy" CRAMINO_UNIQ() is exact
> > what is needed. In your orginal design of cramfs there is no way to give
> > entries with no data an unique inode number.
>
> Umm. And my cramino() did exactly that. If it has a data pointer, it
> uses that, otherwise it uses the directory offset.
>
The current implementation does it not.
> It just doesn't care about the mode of the file.
>
Right, but there are a buggy cramfs tools (which can create images for
different endian target or create on the fly devices nodes and so on)
out there, which set the offset of the cramfs_inode to a value not equal
0. This works well with older kernel like 2.6.12 but during the
evolution of the kernel this was broken.
I will resend a cleaned up patch. Hope you will apply it ;-)
Stefani
next prev parent reply other threads:[~2010-12-16 9:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 23:12 [PATCH] cramfs: generate unique inode number for better inode cache usage stefani
2010-12-14 23:32 ` Linus Torvalds
2010-12-14 23:43 ` Linus Torvalds
2010-12-15 7:50 ` Stefani Seibold
2010-12-15 8:15 ` Pekka Enberg
2010-12-15 15:51 ` Linus Torvalds
2010-12-15 16:31 ` stefani
2010-12-15 16:45 ` Linus Torvalds
2010-12-16 9:47 ` Stefani Seibold [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-12-16 16:40 stefani
2010-12-16 9:52 stefani
2010-12-16 11:45 ` Pekka Enberg
2010-12-12 10:48 stefani
2010-12-14 20:51 ` Andrew Morton
2010-12-14 21:02 ` Stefani Seibold
2010-12-14 21:12 ` Andrew Morton
2010-12-14 21:27 ` Stefani Seibold
2010-12-14 21:08 ` Linus Torvalds
2010-12-14 21:24 ` Stefani Seibold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292492842.3019.5.camel@wall-e \
--to=stefani@seibold.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.