From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756489Ab0LPP3R (ORCPT ); Thu, 16 Dec 2010 10:29:17 -0500 Received: from casper.infradead.org ([85.118.1.10]:35186 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756458Ab0LPP3Q convert rfc822-to-8bit (ORCPT ); Thu, 16 Dec 2010 10:29:16 -0500 Subject: Re: [RFC][PATCH 3/5] sched: Change the ttwu success details From: Peter Zijlstra To: Frederic Weisbecker Cc: Chris Mason , Frank Rowand , Ingo Molnar , Thomas Gleixner , Mike Galbraith , Oleg Nesterov , Paul Turner , Jens Axboe , linux-kernel@vger.kernel.org In-Reply-To: <20101216152351.GB1687@nowhere> References: <20101216145602.899838254@chello.nl> <20101216150920.866959114@chello.nl> <20101216152351.GB1687@nowhere> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Thu, 16 Dec 2010 16:27:55 +0100 Message-ID: <1292513275.6803.4603.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2010-12-16 at 16:23 +0100, Frederic Weisbecker wrote: > > - TP_printk("comm=%s pid=%d prio=%d success=%d target_cpu=%03d", > > + TP_printk("comm=%s pid=%d prio=%d target_cpu=%03d", > > __entry->comm, __entry->pid, __entry->prio, > > - __entry->success, __entry->target_cpu) > > + __entry->target_cpu) > > Note we'll need to fix some perf scripts after that. And also perf sched, > probably perf timechart and so on... Do any of those actually use the success parameter? If not, then me removing it shouldn't break those tools since they're supposed to parse the format stuff and not notice it missing ;-)