From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Lianhao Lu <lianhao.lu@intel.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 1/1] meta-environment: Added package of meta-environment-${TARGET_ARCH} for environment files.
Date: Thu, 16 Dec 2010 15:49:56 +0000 [thread overview]
Message-ID: <1292514596.26558.4040.camel@rex> (raw)
In-Reply-To: <39f0fc7689c9ddf429a5a2fd4fad7e74c0d98bb6.1292464057.git.lianhao.lu@intel.com>
Hi Lianhao,
On Thu, 2010-12-16 at 09:40 +0800, Lianhao Lu wrote:
> [BUGID #565] Fixing bug #565, added package of
> meta-environment-${TARGET_ARCH} for environment files used by
> cross-canadian toolchain.
>
> Also corrected the situation of empty config site file for target.
>
> Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
> ---
> meta/classes/toolchain-scripts.bbclass | 32 ++++++++++
> meta/recipes-core/meta/meta-environment.bb | 75 ++++++++++++++++++++++++
> meta/recipes-core/tasks/task-cross-canadian.bb | 1 +
> 3 files changed, 108 insertions(+), 0 deletions(-)
> create mode 100644 meta/recipes-core/meta/meta-environment.bb
This recipe looks complex and seems to include a lot of
cross-canadian.bbclass.
Would it be possible to inherit that class instead and try and keep the
recipe simpler? You can always drop the "meta" inherit. I'm worried
about the amount of code duplication here.
Cheers,
Richard
next prev parent reply other threads:[~2010-12-16 15:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 1:47 [PATCH 0/1] [BUGID #565] fixing. Added package of meta-environment-${TARGET_ARCH} Lianhao Lu
2010-12-16 1:40 ` [PATCH 1/1] meta-environment: Added package of meta-environment-${TARGET_ARCH} for environment files Lianhao Lu
2010-12-16 15:49 ` Richard Purdie [this message]
2010-12-17 2:30 ` Lu, Lianhao
2010-12-20 17:29 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292514596.26558.4040.camel@rex \
--to=richard.purdie@linuxfoundation.org \
--cc=lianhao.lu@intel.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.