All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
To: Michel Hermier <michel.hermier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: mesa: Patch that fix/add missing WAIT_RING calls
Date: Thu, 16 Dec 2010 17:20:58 +0100	[thread overview]
Message-ID: <1292516458.2113.21.camel@Portable-Work> (raw)
In-Reply-To: <AANLkTinj4TObB1Mb9mG3T74OQiyKd+vK1Dk-WYuT6=Qc-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hi Michel,

had a short look on this, as far as i can tell at the time the patch
looks fairly good and we really need this checks.

Some small notes:

1. In loops with fixed iterations the WAIT_RING should be called before
the loop, not inside. I think it is ok if we waste a few pushbuf entries
to avoid calling libdrm too often.

See for example nvfx_push_vbo and nvfx_render_prim.

2. You decreased the size of the checks in several places. We should
review all of them before pushing this changes. I remember some of them
had some offset for some crude reason. I will review them by this
weekend if no one does it earlier.

-- lynxeye


Am Donnerstag, den 16.12.2010, 12:22 +0100 schrieb Michel Hermier:
> Hi,
> While trying to run a 3D app I needed to modify/add some WAIT_RING
> calls so the push buffer is properly checked, before we try to blindly
> push to it (sine OUT_RING don't perform this checks yet, I have a
> small patch for that for libdrm).
> I allready discussed about it with lynxeye and shining on IRC.
> _______________________________________________
> Nouveau mailing list
> Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> http://lists.freedesktop.org/mailman/listinfo/nouveau

  parent reply	other threads:[~2010-12-16 16:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-16 11:22 mesa: Patch that fix/add missing WAIT_RING calls Michel Hermier
     [not found] ` <AANLkTinj4TObB1Mb9mG3T74OQiyKd+vK1Dk-WYuT6=Qc-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-12-16 16:20   ` Lucas Stach [this message]
2010-12-17  9:23     ` Michel Hermier
2010-12-19 13:32   ` Xavier Chantry
     [not found]     ` <AANLkTikmqfYmmNqrNxYAn9f2KiP6V2fk01uCLuOnGZSj-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-12-20  9:16       ` Michel Hermier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1292516458.2113.21.camel@Portable-Work \
    --to=dev-8ppwabl0hbeelga04laivw@public.gmane.org \
    --cc=michel.hermier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.