From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH v2 7/9] ofono-rules: Add cdmagen device
Date: Sat, 18 Dec 2010 19:31:05 +0100 [thread overview]
Message-ID: <1292697065.2658.14.camel@aeonflux> (raw)
In-Reply-To: <1292627481-9109-8-git-send-email-dara.spieker-doyle@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 992 bytes --]
Hi Dara,
> plugins/ofono.rules | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/plugins/ofono.rules b/plugins/ofono.rules
> index da8a8ef..34698f0 100644
> --- a/plugins/ofono.rules
> +++ b/plugins/ofono.rules
> @@ -429,6 +429,10 @@ ATTRS{idVendor}=="0930", ATTRS{idProduct}=="1311", ENV{OFONO_DRIVER}="mbm"
> # Nokia Internet Stick CS-10
> ATTRS{idVendor}=="0421", ATTRS{idProduct}=="060e", ENV{OFONO_DRIVER}="nokia"
>
> +# Nokia CDMA Device
> +ATTRS{idVendor}=="0421", ATTRS{idProduct}=="023e", ENV{OFONO_DRIVER}="cdmagen"
> +ATTRS{idVendor}=="0421", ATTRS{idProduct}=="00b6", ENV{OFONO_DRIVER}="cdmagen"
> +
since this is Nokia specific device, then using nokiacdma would be a
better name. Or using OFONO_DRIVER=nokia NOKIA_MODE=cdma and sharing the
driver might be useful.
It really all depends how much they have in common. So what kind of
hardware is this actually? A phone or a real USB dongle?
Regards
Marcel
next prev parent reply other threads:[~2010-12-18 18:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 23:11 [PATCH v2 7/9] ofono-rules: Add cdmagen device Dara Spieker-Doyle
2010-12-18 18:31 ` Marcel Holtmann [this message]
2010-12-20 18:31 ` Dara Spieker-Doyle
2010-12-21 14:23 ` Marcel Holtmann
2010-12-21 17:47 ` Dara Spieker-Doyle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292697065.2658.14.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.