From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Clifton Subject: Re: BISECTED: Suspend regression on drm-intel-next Date: Sun, 19 Dec 2010 10:05:25 +0000 Message-ID: <1292753125.2386.2.camel@pcjc2lap> References: <1292702541.3071.7.camel@pcjc2lap> <849307$aqoaem@azsmga001.ch.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from ppsw-41.csi.cam.ac.uk (ppsw-41.csi.cam.ac.uk [131.111.8.141]) by gabe.freedesktop.org (Postfix) with ESMTP id 9F7159E738 for ; Sun, 19 Dec 2010 02:05:27 -0800 (PST) In-Reply-To: <849307$aqoaem@azsmga001.ch.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Intel List-Id: intel-gfx@lists.freedesktop.org On Sat, 2010-12-18 at 21:42 +0000, Chris Wilson wrote: > On Sat, 18 Dec 2010 20:02:21 +0000, Peter Clifton wrote: > > Hi Chris, > > > > I bisected the suspend regression I mentioned, and came to this commit: > > > > commit 0cdab21f9a1fca50dd27e488839f5a6578e333b2 > > Author: Chris Wilson > > Date: Sun Dec 5 17:27:06 2010 +0000 > > > > drm/i915: Uncouple render/power ctx before suspending > > > > Signed-off-by: Chris Wilson > > > > > > Disabling power context tear down on suspend with this diff: > > And you verified the revert against drm-intel-next HEAD? I'll revert just > as soon as I see your confirmation. :) Confirmed.. drm-intel-next is still broken. I'm vaguely curious why it makes it lock up, but I'll settle for it not doing so ;) Only since suspend has been broken did I realise just how much I rely upon it! > [The patch was only trying to see if it made Ironlake stable on suspending > with renderctx, to no avail so there should be no repercussions in > reverting.] Good to hear. Best wishes, -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me)