From: Jassi@alsa-project.org, "Brar <jassisinghbrar"@gmail.com
To: alsa-devel@alsa-project.org
Cc: lrg@slimlogic.co.uk, kgene.kim@samsung.com,
Jassi Brar <jassi.brar@samsung.com>,
broonie@opensource.wolfsonmicro.com
Subject: [PATCH 02/10] ASoC: Samsung: I2S: Flush FIFO after stop
Date: Mon, 20 Dec 2010 11:05:47 +0900 [thread overview]
Message-ID: <1292810747-29968-1-git-send-email-jassisinghbrar@gmail.com> (raw)
In-Reply-To: <1292810667-29773-1-git-send-email-jassisinghbrar@gmail.com>
From: Jassi Brar <jassi.brar@samsung.com>
Flush the FIFO while stopping the channel rather than starting.
This saves time during stream start and keeps the FIFOs clean
when the channel is idling.
Signed-off-by: Jassi Brar <jassi.brar@samsung.com>
---
sound/soc/samsung/i2s.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
index 26b4bdf..d00ac3a 100644
--- a/sound/soc/samsung/i2s.c
+++ b/sound/soc/samsung/i2s.c
@@ -843,11 +843,6 @@ static int i2s_trigger(struct snd_pcm_substream *substream,
case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
local_irq_save(flags);
- if (capture)
- i2s_fifo(i2s, FIC_RXFLUSH);
- else
- i2s_fifo(i2s, FIC_TXFLUSH);
-
if (config_setup(i2s)) {
local_irq_restore(flags);
return -EINVAL;
@@ -870,6 +865,11 @@ static int i2s_trigger(struct snd_pcm_substream *substream,
else
i2s_txctrl(i2s, 0);
+ if (capture)
+ i2s_fifo(i2s, FIC_RXFLUSH);
+ else
+ i2s_fifo(i2s, FIC_TXFLUSH);
+
local_irq_restore(flags);
break;
}
--
1.6.2.5
next prev parent reply other threads:[~2010-12-20 2:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 2:04 [PATCHes 00/10] ASoC: Samsung: Enable latest SoCs Jassi, Brar <jassisinghbrar
2010-12-20 2:05 ` [PATCH 01/10] ASoC: Samsung: Set default rclk source rate Jassi, Brar <jassisinghbrar
2010-12-20 2:05 ` Jassi, Brar <jassisinghbrar [this message]
2010-12-20 2:05 ` [PATCH 03/10] ASoC: SMDK_WM8580: Make I2S0 as default dai Jassi, Brar <jassisinghbrar
2010-12-20 2:05 ` [PATCH 04/10] ASoC: SMDK6440: Enable I2S device Jassi, Brar <jassisinghbrar
2010-12-20 2:05 ` [PATCH 05/10] ASoC: SMDK6450: " Jassi, Brar <jassisinghbrar
2010-12-20 13:43 ` Mark Brown
2010-12-20 2:05 ` [PATCH 06/10] ASoC: SMDK6442: " Jassi, Brar <jassisinghbrar
2010-12-20 2:05 ` [PATCH 07/10] ASoC: SMDKV210: " Jassi, Brar <jassisinghbrar
2010-12-20 2:05 ` [PATCH 08/10] ASoC: SMDKC110: " Jassi, Brar <jassisinghbrar
2010-12-20 2:05 ` [PATCH 09/10] ASoC: SMDKV310: Enable AC97 device Jassi, Brar <jassisinghbrar
2010-12-20 2:05 ` [PATCH 10/10] ASoC: SMDKV310: Add I2S support Jassi, Brar <jassisinghbrar
2010-12-20 13:41 ` Mark Brown
2010-12-20 9:32 ` [PATCHes 00/10] ASoC: Samsung: Enable latest SoCs Liam Girdwood
2010-12-20 13:45 ` Mark Brown
2010-12-21 1:53 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292810747-29968-1-git-send-email-jassisinghbrar@gmail.com \
--to=jassi@alsa-project.org \
--cc="Brar <jassisinghbrar"@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jassi.brar@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.