All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Herbszt <herbszt@gmx.de>
To: qemu-devel@nongnu.org
Cc: Sebastian Herbszt <herbszt@gmx.de>
Subject: [Qemu-devel] [PATCH] usb-uhci: use pci_config_set_revision()
Date: Mon, 20 Dec 2010 22:45:25 +0100	[thread overview]
Message-ID: <1292881525$2258@local> (raw)

Use pci_config_set_revision().

Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>

diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c
index b9b822f..5b3bf21 100644
--- a/hw/usb-uhci.c
+++ b/hw/usb-uhci.c
@@ -1106,7 +1106,7 @@ static int usb_uhci_common_initfn(UHCIState *s)
     uint8_t *pci_conf = s->dev.config;
     int i;
 
-    pci_conf[PCI_REVISION_ID] = 0x01; // revision number
+    pci_config_set_revision(pci_conf, 0x01); // revision number
     pci_conf[PCI_CLASS_PROG] = 0x00;
     pci_config_set_class(pci_conf, PCI_CLASS_SERIAL_USB);
     /* TODO: reset value should be 0. */

                 reply	other threads:[~2010-12-20 21:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='1292881525$2258@local' \
    --to=herbszt@gmx.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.