Re: [PATCH 1/1] send-pull-request: Use current date in mail headers

[Joshua Lock <josh@linux.intel.com>]

On Mon, 2010-12-20 at 10:50 -0800, Darren Hart wrote:
> Some users experience problems viewing the pull requests as a sequential
> mail series due to the script using the git commit date for the patches
> and today's date for the cover letter.
> 
> Address this by renaming the email Date: header to Old-Date: and adding
> a new Date: header with a current timestamp.
> 
> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
> Reported-by: Gary Thomas <gary@mlbassoc.com>
> Cc: Josh Lock <josh@linux.intel.com>

Acked-by: Joshua Lock <josh@linux.intel.com>

> ---
>  scripts/send-pull-request |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/send-pull-request b/scripts/send-pull-request
> index 0576a5d..03a78f9 100755
> --- a/scripts/send-pull-request
> +++ b/scripts/send-pull-request
> @@ -118,7 +118,11 @@ if [ "$cont" == "y" ] || [ "$cont" == "Y" ]; then
>          # 
>          # Use tail to remove the email envelope from git or formail as
>          # msmtp (sendmail) would choke on them.
> -        cat $PATCH | formail -I "To: $TO" -I "CC: $CC" | tail -n +2 | sendmail -t
> +        #
> +        # Modify the patch date for sequential delivery, but retain the
> +        # original date as "Old-Date".
> +        DATE=$(date +"%a, %d %b %Y %k:%M:%S %z")
> +        cat $PATCH | formail -I "To: $TO" -I "CC: $CC" -i "Date: $DATE" | tail -n +2 | sendmail -t
>          if [ $? -eq 1 ]; then
>              ERROR=1
>          fi

-- 
Joshua Lock
        Intel Open Source Technology Centre