From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Joshua Lock <josh@openedhand.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 0/1] SRC_URI checksum support v3
Date: Tue, 21 Dec 2010 11:04:06 +0000 [thread overview]
Message-ID: <1292929446.25087.5890.camel@rex> (raw)
In-Reply-To: <1292928863.2701.2.camel@scimitar>
On Tue, 2010-12-21 at 10:54 +0000, Joshua Lock wrote:
> On Tue, 2010-12-21 at 13:32 +0800, Yu Ke wrote:
> > BTW, I am also thinking if we could merge Fetch.write_md5sum and
> > Fetch.verify_md5sum into verify_checksum, since they are all checksum
> > related, puting them together would be more clean logically.
>
> That makes the assumption that you only want to verify a checksum when
> fetching one, which I don't think is correct?
We really only want to take the time to compute the checksums once, then
mark something to say we've checked it and move on.
I think the use of the ".md5" file is misleading and we should probably
find a more logical approach to this but in principle checking after
download should be ok. We can always have something to enable a recheck
if the user really wanted it I guess but most of the time it will be a
waste of time.
Cheers,
Richard
next prev parent reply other threads:[~2010-12-21 11:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 6:33 [PATCH 0/1] SRC_URI checksum support v3 Yu Ke
2010-12-17 5:52 ` [PATCH 1/1] FetchData: add SRC_URI checksum Yu Ke
2010-12-20 16:10 ` [PATCH 0/1] SRC_URI checksum support v3 Richard Purdie
2010-12-21 5:32 ` Yu Ke
2010-12-21 10:54 ` Joshua Lock
2010-12-21 11:04 ` Richard Purdie [this message]
2010-12-21 13:17 ` Yu Ke
2010-12-21 13:25 ` Yu Ke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292929446.25087.5890.camel@rex \
--to=richard.purdie@linuxfoundation.org \
--cc=josh@openedhand.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.