Re: Bug#599345: linux-image-2.6.32-5-amd64: iwlagn allocation failure

[Ben Hutchings <ben@decadent.org.uk>]

[-- Attachment #1: Type: text/plain, Size: 800 bytes --]

On Wed, 2010-10-13 at 17:30 +0200, Johannes Berg wrote:
> On Wed, 2010-10-13 at 17:17 +0200, Julien Cristau wrote:
> 
> > Getting lots of those in dmesg:
> > iwlagn 0000:0c:00.0: Too many chunks: 2
> > 
> > Doesn't seem to prevent the network from working though.
> 
> It'll at least leak lots of memory though. But I think the check there
> is just wrong -- there are TFDs, and there are SKBs, and we need two
> TFDs, but just one SKB.

Right.  The old condition:
	if (num_tbs >= IWL_NUM_OF_TBS) {
should have been:
	if (num_tbs > IWL_NUM_OF_TBS) {
though in practice neither condition was possible.

In the minimal patch, the condition should be changed to:
	if (num_tbs > 2) {

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]