All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH v2, 7/7] cdmaphonesim: Add CDMA SMS Support
Date: Wed, 22 Dec 2010 05:41:42 -0800	[thread overview]
Message-ID: <1293025302.2658.74.camel@aeonflux> (raw)
In-Reply-To: <1292976149-15598-8-git-send-email-lei.2.yu@nokia.com>

[-- Attachment #1: Type: text/plain, Size: 897 bytes --]

Hi Lei,

>  Makefile.am               |   10 ++
>  plugins/cdmaphonesim.c    |  328 +++++++++++++++++++++++++++++++++++++++++++++
>  plugins/cdmaphonesim.conf |   14 ++
>  3 files changed, 352 insertions(+), 0 deletions(-)
>  create mode 100644 plugins/cdmaphonesim.c
>  create mode 100644 plugins/cdmaphonesim.conf

do we really want to do it this way? I am not so sure that this is the
best way.

I would prefer to just have one /etc/ofono/phonesim.conf configuration
file. And maybe we need to start splitting phonesim plugin into a view
pieces and move it to its own directory. It then could also contain its
own atom driver implementations there.

So my main concern here is really that phonesim support is just for
engineering. It has nothing to do with real production hardware. And I
don't wanna clutter the source or its installation with it.

Regards

Marcel



  reply	other threads:[~2010-12-22 13:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-22  0:02 [PATCH v2, 7/7] cdmaphonesim: Add CDMA SMS Support Lei Yu
2010-12-22 13:41 ` Marcel Holtmann [this message]
2010-12-22 16:14   ` Lei Yu
2010-12-22 16:09     ` Marcel Holtmann
2010-12-22 16:23       ` Lei Yu
2010-12-22 21:07         ` Lei Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1293025302.2658.74.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.