All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lin Ming <ming.m.lin@intel.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: "Moore, Robert" <robert.moore@intel.com>,
	Len Brown <lenb@kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"Brown, Len" <len.brown@intel.com>
Subject: Re: [PATCH 3/3] ACPI / ACPICA: Disable GPEs during initialization
Date: Tue, 28 Dec 2010 08:50:55 +0800	[thread overview]
Message-ID: <1293497455.2565.328.camel@minggr.sh.intel.com> (raw)
In-Reply-To: <201012272116.23678.rjw@sisk.pl>

On Tue, 2010-12-28 at 04:16 +0800, Rafael J. Wysocki wrote:
> Hi,
> 
> The patch below is needed in the ACPICA core.

Thanks, and I'm also looking at below patch

ACPI / ACPICA: Fix global lock acquisition
https://bugzilla.novell.com/show_bug.cgi?id=637377#c82


Lin Ming

> 
> On Sunday, December 26, 2010, Len Brown wrote:
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> > 
> > GPEs with corresponding _Lxx/_Exx control methods need to be disabled
> > during initialization in case they have been enabled by the BIOS, so
> > that they don't fire up until they are enabled by acpi_update_gpes().
> > 
> > References: https://bugzilla.kernel.org/show_bug.cgi?id=25412
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> > Signed-off-by: Len Brown <len.brown@intel.com>
> > ---
> >  drivers/acpi/acpica/evgpeinit.c |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/acpi/acpica/evgpeinit.c b/drivers/acpi/acpica/evgpeinit.c
> > index 2c7def9..4c8dea5 100644
> > --- a/drivers/acpi/acpica/evgpeinit.c
> > +++ b/drivers/acpi/acpica/evgpeinit.c
> > @@ -408,6 +408,9 @@ acpi_ev_match_gpe_method(acpi_handle obj_handle,
> >  		return_ACPI_STATUS(AE_OK);
> >  	}
> >  
> > +	/* Disable the GPE in case it's been enabled already. */
> > +	(void)acpi_hw_low_set_gpe(gpe_event_info, ACPI_GPE_DISABLE);
> > +
> >  	/*
> >  	 * Add the GPE information from above to the gpe_event_info block for
> >  	 * use during dispatch of this GPE.
> > 
> 



  reply	other threads:[~2010-12-28  0:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-26 22:39 ACPI patches for 2.6.37-rc-7 Len Brown
2010-12-26 22:39 ` [PATCH 1/3] ACPI: Execute _PRW for devices reported as inactive or not present Len Brown
2010-12-26 22:39   ` [PATCH 2/3] Revert "ACPI battery: update status upon sysfs query" Len Brown
2010-12-26 22:39   ` [PATCH 3/3] ACPI / ACPICA: Disable GPEs during initialization Len Brown
2010-12-27 20:16     ` Rafael J. Wysocki
2010-12-28  0:50       ` Lin Ming [this message]
2010-12-28  9:49         ` Rafael J. Wysocki
2011-01-07 20:41       ` Moore, Robert
2011-01-07 21:14         ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1293497455.2565.328.camel@minggr.sh.intel.com \
    --to=ming.m.lin@intel.com \
    --cc=len.brown@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=robert.moore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.