Re: [PATCH] apic: use GFP_ATOMIC in lapic_resume

[Zhang Rui <rui.zhang@intel.com>]

On Tue, 2010-12-28 at 15:00 +0800, David Rientjes wrote:
> On Tue, 28 Dec 2010, Zhang Rui wrote:
> 
> > Index: linux-2.6/arch/x86/kernel/apic/apic.c
> > ===================================================================
> > --- linux-2.6.orig/arch/x86/kernel/apic/apic.c
> > +++ linux-2.6/arch/x86/kernel/apic/apic.c
> > @@ -1459,7 +1459,7 @@ void __init enable_IR_x2apic(void)
> >  	if (dmar_table_init_ret && !x2apic_supported())
> >  		return;
> >  
> > -	ioapic_entries = alloc_ioapic_entries();
> > +	ioapic_entries = alloc_ioapic_entries(GFP_KERNEL);
> >  	if (!ioapic_entries) {
> >  		pr_err("Allocate ioapic_entries failed\n");
> >  		goto out;
> > @@ -2084,7 +2084,7 @@ static int lapic_resume(struct sys_devic
> >  
> >  	local_irq_save(flags);
> >  	if (intr_remapping_enabled) {
> > -		ioapic_entries = alloc_ioapic_entries();
> > +		ioapic_entries = alloc_ioapic_entries(GFP_ATOMIC);
> >  		if (!ioapic_entries) {
> >  			WARN(1, "Alloc ioapic_entries in lapic resume failed.");
> >  			ret = -ENOMEM;
> 
> You can't do the allocation before disabling irqs when 
> intr_remapping_enabled is set?

yes, we can. The first idea came into my mind is to register a pm
notifier callback to allocate/free the memory. But that one duplicates
the code of alloc_ioapic_entries, which doesn't look nice, neither.
Plus, is there any problem with this one?

thanks,
rui
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/