From: Luciano Coelho <luciano.coelho@nokia.com>
To: ext Arik Nemtsov <arik@wizery.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 06/18] wl1271: AP mode - init sequence
Date: Tue, 28 Dec 2010 10:34:09 +0200 [thread overview]
Message-ID: <1293525249.19215.3074.camel@powerslave> (raw)
In-Reply-To: <AANLkTikrgQwxBKSc_s-DHU+ktU+HwHb1hBukL+0rgpYK@mail.gmail.com>
On Tue, 2010-12-28 at 08:16 +0200, ext Arik Nemtsov wrote:
> >> diff --git a/drivers/net/wireless/wl12xx/init.h
> b/drivers/net/wireless/wl12xx/init.h
> >> index 7762421..4d37210 100644
> >> --- a/drivers/net/wireless/wl12xx/init.h
> >> +++ b/drivers/net/wireless/wl12xx/init.h
> >> @@ -27,10 +27,13 @@
> >> #include "wl12xx.h"
> >>
> >> int wl1271_hw_init_power_auth(struct wl1271 *wl);
> >> -int wl1271_init_templates_config(struct wl1271 *wl);
> >> +int wl1271_sta_init_templates_config(struct wl1271 *wl);
> >> int wl1271_init_phy_config(struct wl1271 *wl);
> >> int wl1271_init_pta(struct wl1271 *wl);
> >> int wl1271_init_energy_detection(struct wl1271 *wl);
> >> int wl1271_hw_init(struct wl1271 *wl);
> >>
> >> +/* Functions from wl1271_main.c */
> >> +u32 wl1271_min_rate_get(struct wl1271 *wl);
> >> +
> >
> > This is bad and shouldn't be here. Need to find a better place for
> it.
>
> How about tx.h? It's TX rate we're talking about here after all.
> I can also change the name to wl1271_tx_min_rate_get().
Sounds good.
--
Cheers,
Luca.
next prev parent reply other threads:[~2010-12-28 8:34 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-22 14:27 [PATCH v2 00/18] AP mode support for wl12xx Arik Nemtsov
2010-12-22 14:27 ` [PATCH v2 01/18] wl1271: Add AP related configuration to conf_drv_settings Arik Nemtsov
2010-12-22 20:22 ` Luciano Coelho
2010-12-23 11:05 ` Arik Nemtsov
2010-12-22 14:27 ` [PATCH v2 02/18] wl1271: AP mode - AP specific CMD_CONFIGURE sub-commands Arik Nemtsov
2010-12-22 20:44 ` Luciano Coelho
2010-12-23 6:48 ` Arik Nemtsov
2010-12-22 14:27 ` [PATCH v2 03/18] wl1271: AP mode - add AP specific event Arik Nemtsov
2010-12-22 14:27 ` [PATCH v2 04/18] wl1271: AP-mode high level commands Arik Nemtsov
2010-12-22 21:16 ` Luciano Coelho
2010-12-23 7:48 ` Arik Nemtsov
2010-12-22 14:27 ` [PATCH v2 05/18] wl1271: AP mode - workaround for FW bug on station remove Arik Nemtsov
2010-12-22 21:19 ` Luciano Coelho
2010-12-23 7:51 ` Arik Nemtsov
2010-12-22 14:27 ` [PATCH v2 06/18] wl1271: AP mode - init sequence Arik Nemtsov
2010-12-27 12:57 ` Luciano Coelho
2010-12-28 6:16 ` Arik Nemtsov
2010-12-28 8:34 ` Luciano Coelho [this message]
2010-12-22 14:27 ` [PATCH v2 07/18] wl1271: AP specific RX filter configuration Arik Nemtsov
2010-12-22 21:29 ` Luciano Coelho
2010-12-23 7:58 ` Arik Nemtsov
2010-12-22 14:27 ` [PATCH v2 08/18] wl1271: Add AP related definitions to HOST-FW interface Arik Nemtsov
2010-12-22 21:36 ` Luciano Coelho
2010-12-23 8:05 ` Arik Nemtsov
2010-12-22 14:27 ` [PATCH v2 09/18] wl1271: Configure AP on BSS info change Arik Nemtsov
2010-12-27 13:11 ` Luciano Coelho
2010-12-27 21:46 ` Arik Nemtsov
2010-12-22 14:27 ` [PATCH v2 10/18] wl1271: AP mode config in ieee80211_ops.config Arik Nemtsov
2010-12-22 14:27 ` [PATCH v2 11/18] wl1271: AP mode - change filter config Arik Nemtsov
2010-12-22 14:27 ` [PATCH v2 12/18] wl1271: AP mode - add STA add/remove ops Arik Nemtsov
2010-12-27 13:34 ` Luciano Coelho
2010-12-28 5:37 ` Arik Nemtsov
2010-12-22 14:27 ` [PATCH v2 13/18] wl1271: AP mode - changes in TX path Arik Nemtsov
2010-12-22 14:27 ` [PATCH v2 14/18] wl1271: AP mode - record TX configuration settings Arik Nemtsov
2010-12-28 11:35 ` Luciano Coelho
2010-12-28 11:37 ` Arik Nemtsov
2010-12-22 14:27 ` [PATCH v2 15/18] wl1271: AP mode - encryption support Arik Nemtsov
2010-12-28 12:03 ` Luciano Coelho
2010-12-28 17:16 ` Arik Nemtsov
2010-12-22 14:27 ` [PATCH v2 16/18] wl1271: AP mode - fetch appropriate firmware for AP Arik Nemtsov
2010-12-22 14:27 ` [PATCH v2 17/18] wl1271: Read MAC address from NVS file on HW startup Arik Nemtsov
2010-12-28 12:57 ` Luciano Coelho
2010-12-22 14:27 ` [PATCH v2 18/18] wl1271: Enable AP-mode Arik Nemtsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1293525249.19215.3074.camel@powerslave \
--to=luciano.coelho@nokia.com \
--cc=arik@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.