Re: [PATCH 3/4] [media] ivtv: Add Adaptec Remote Controller

[Andy Walls <awalls@md.metrocast.net>]

On Thu, 2010-12-30 at 11:30 -0200, Mauro Carvalho Chehab wrote:
> Em 30-12-2010 10:36, Andy Walls escreveu:


> Thanks for the review. Version 3 of the patch enclosed.

Still one little mistake that matters, otherwise it looks good.
See below...

> commit 8576bd14361ec75c91ddfb49cc2df389143cf06a
> Author: Mauro Carvalho Chehab <mchehab@redhat.com>
> Date:   Thu Dec 30 09:31:10 2010 -0200
> 
>     [media] ivtv: Add Adaptec Remote Controller
>     

>  
>  /* This array should match the IVTV_HW_ defines */
> @@ -143,8 +145,34 @@ static const char * const hw_devicenames[] = {
>  	"ir_video",		/* IVTV_HW_I2C_IR_RX_HAUP_INT */
>  	"ir_tx_z8f0811_haup",	/* IVTV_HW_Z8F0811_IR_TX_HAUP */
>  	"ir_rx_z8f0811_haup",	/* IVTV_HW_Z8F0811_IR_RX_HAUP */
> +	"ir_adaptec",		/* IVTV_HW_I2C_IR_RX_ADAPTEC */
>  };
 
This either needs to be "ir_video", or you need to add "ir_adaptec" to
the i2c_device_id[] array in ir-kbd-i2c.c.  Otherwise ir-kbd-i2c.c won't
claim the device and use it.

Upon fixing that

Reviewed-by: Andy Walls <awalls@md.metrocast.net>
Acked-by: Andy Walls <awalls@md.metrocast.net>


Regards,
Andy