From: Johannes Berg <johannes@sipsolutions.net>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: [PATCH 1/1 V3] bridge: fix br_multicast_ipv6_rcv for paged skbs
Date: Mon, 03 Jan 2011 10:34:14 +0100 [thread overview]
Message-ID: <1294047254.4165.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1293999538-9298-1-git-send-email-tomas.winkler@intel.com>
On Sun, 2011-01-02 at 22:18 +0200, Tomas Winkler wrote:
> icmp6h = icmp6_hdr(skb2);
>
> switch (icmp6h->icmp6_type) {
> @@ -1516,7 +1517,12 @@ static int br_multicast_ipv6_rcv(struct net_bridge *br,
> switch (icmp6h->icmp6_type) {
> case ICMPV6_MGM_REPORT:
> {
> - struct mld_msg *mld = (struct mld_msg *)icmp6h;
> + struct mld_msg *mld;
> + if (!pskb_may_pull(skb2, sizeof(*mld))) {
> + err = -EINVAL;
> + goto out;
> + }
> + mld = (struct mld_msg *)icmp6h;
This (and the second instance) is incorrect afaict -- the pointer
"icmp6h" should be reloaded after the pskb_may_pull(), no?
Also, the "out_nopush" thing is pointless since the push is completely
unnecessary as "skb2 != skb" is always true.
johannes
next prev parent reply other threads:[~2011-01-03 9:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-02 20:18 [PATCH 1/1 V3] bridge: fix br_multicast_ipv6_rcv for paged skbs Tomas Winkler
2011-01-03 9:34 ` Johannes Berg [this message]
2011-01-03 9:43 ` Winkler, Tomas
2011-01-03 10:04 ` Johannes Berg
2011-01-03 10:17 ` Winkler, Tomas
2011-01-03 10:41 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294047254.4165.1.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.