All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Cc: linux-wireless@vger.kernel.org
Subject: Re: OOPS at ieee80211_aes_ccm_encrypt()?
Date: Mon, 03 Jan 2011 17:46:30 +0100	[thread overview]
Message-ID: <1294073190.3436.2.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20110103001006.13085vt89qfm6pcs@hayate.sektori.org>

On Mon, 2011-01-03 at 00:10 +0200, Jussi Kivilinna wrote:

> While doing stress testing on zd1211rw AP-mode I run into this problem  
> that I don't think has that much to do with zd1211rw:

[snip]

> Is key being used after freeing?

It looks like it. Can you reproduce this fairly easily? I wonder if it's
an RCU problem, we do key lookups under RCU but I see no grace period
right now ... try the patch below, I'll look into it in more detail.

johannes

--- wireless-testing.orig/net/mac80211/key.c	2011-01-03 17:44:54.000000000 +0100
+++ wireless-testing/net/mac80211/key.c	2011-01-03 17:45:41.000000000 +0100
@@ -379,6 +379,8 @@ static void __ieee80211_key_destroy(stru
 	if (!key)
 		return;
 
+	synchronize_rcu();
+
 	if (key->local)
 		ieee80211_key_disable_hw_accel(key);
 



  reply	other threads:[~2011-01-03 16:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-02 22:10 OOPS at ieee80211_aes_ccm_encrypt()? Jussi Kivilinna
2011-01-03 16:46 ` Johannes Berg [this message]
2011-01-03 18:11   ` Jussi Kivilinna
2011-01-03 18:16     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1294073190.3436.2.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=jussi.kivilinna@mbnet.fi \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.